Conversation
Signed-off-by: Dong Hyuk Chang <9426164+thomasdhc@users.noreply.github.com>
thomasdhc
requested review from
HuiyingLi,
ZhiyuLi-Nvidia,
adil-a,
akoumpa and
hemildesai
torsli
reviewed
Apr 1, 2026
Contributor
torsli
left a comment
torsli
left a comment
There was a problem hiding this comment.
Each golden value file is linked to a specific example. Is there a system in place to automatically update or deprecate the golden values if the system changes?
Some are blank and I'm not sure why. Otherwise, LGTM.
Contributor
There was a problem hiding this comment.
This file is blank. Is that expected?
Contributor
There was a problem hiding this comment.
just wanted to highlight all of them.
Signed-off-by: Dong Hyuk Chang <9426164+thomasdhc@users.noreply.github.com>
torsli
approved these changes
Apr 2, 2026
linnanwang
pushed a commit
that referenced
this pull request
Apr 24, 2026
* Add golden values Signed-off-by: Dong Hyuk Chang <9426164+thomasdhc@users.noreply.github.com> * Remove empty golden values Signed-off-by: Dong Hyuk Chang <9426164+thomasdhc@users.noreply.github.com> --------- Signed-off-by: Dong Hyuk Chang <9426164+thomasdhc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information