fix: update gemma4 configs and doc with correct model IDs#1670
Merged
Conversation
HuiyingLi
requested review from
ZhiyuLi-Nvidia,
adil-a,
akoumpa,
hemildesai,
jgerh and
pthombre
as code owners
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Huiying Li <willwin.lee@gmail.com>
HuiyingLi
force-pushed
the
huiyingl/gemma4_config_doc_fixes
branch
from
5be3a84 to
355df62
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Huiying Li <willwin.lee@gmail.com>
Contributor
Author
|
/ok to test c31f307 |
linnanwang
pushed a commit
that referenced
this pull request
Apr 24, 2026
* fix: update gemma4 configs and doc fixes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Huiying Li <willwin.lee@gmail.com> * fix: replace path/to placeholders with real model IDs in gemma4 tutorial Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Huiying Li <willwin.lee@gmail.com> --------- Signed-off-by: Huiying Li <willwin.lee@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google/gemma-4-*) in all gemma4 YAML configswandbconfig blocks in YAML examples so they don't require users to fill in credentials before running🤖 Generated with Claude Code