cp: fix: Allow use_cache w/ activation_checkpointing (1726) into r0.4.0#1760
Merged
cp: fix: Allow use_cache w/ activation_checkpointing (1726) into r0.4.0#1760
fix: Allow use_cache w/ activation_checkpointing (1726) into r0.4.0#1760Conversation
* Allow use_cache when activation_checkpointing is True Signed-off-by: Abhishree Thittenamane <athittenaman@cw-dfw-cs-001-login-02.cm.cluster> * Fix lint errors Signed-off-by: Abhishree <abhishreetm@gmail.com> * Fix imports linting Signed-off-by: Abhishree <abhishreetm@gmail.com> * Add tests Signed-off-by: Abhishree Thittenamane <athittenaman@cw-dfw-cs-001-login-02.cm.cluster> * Add more tests Signed-off-by: root <root@pool0-01595.cm.cluster> --------- Signed-off-by: Abhishree Thittenamane <athittenaman@cw-dfw-cs-001-login-02.cm.cluster> Signed-off-by: Abhishree <abhishreetm@gmail.com> Signed-off-by: root <root@pool0-01595.cm.cluster> Co-authored-by: Abhishree Thittenamane <athittenaman@cw-dfw-cs-001-login-02.cm.cluster> Co-authored-by: root <root@pool0-01595.cm.cluster> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
svcnvidia-nemo-ci
requested review from
HuiyingLi,
ZhiyuLi-Nvidia,
adil-a,
akoumpa,
hemildesai and
pthombre
as code owners
Contributor
Author
|
/ok to test 75fa1ee |
akoumpa
changed the title
fix: Allow use_cache when activation_checkpointing is True (1726) into r0.4.0fix: Allow use_cache w/ activation_checkpointing (1726) into r0.4.0
Contributor
|
/ok to test 4e63025 |
Contributor
|
/ok to test b936976 |
Contributor
|
/ok to test 83beea9 |
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Contributor
|
/ok to test b5cfffe |
Contributor
|
Quick note: Removes |
akoumpa
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beep boop [🤖]: Hi @athitten 👋,