Conversation
…iate() (#1827) fix: resolve env vars in loader before merging runtime kwargs resolve_yaml_env_vars was called after config_kwargs.update(kwargs), which caused it to scan actual batch data (examples, processor) passed at collate time. Any training sample containing a bare $VAR pattern (e.g. $P) triggered a spurious KeyError. Fix: call resolve_yaml_env_vars on config-derived kwargs only, then merge the runtime kwargs afterward so data content is never scanned. Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
svcnvidia-nemo-ci
requested review from
HuiyingLi,
ZhiyuLi-Nvidia,
adil-a,
hemildesai and
pthombre
as code owners
Contributor
Author
|
/ok to test d5f9181 |
akoumpa
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beep boop [🤖]: Hi @khazic 👋,