Conversation
#1835) fix: gpt_oss_20b_single_gpu_peft CI crash with `nproc_per_node` override The single-GPU gpt_oss_20b peft recipe was being launched with 8 GPUs in CI, causing a `ValueError: Unexpected dimension name: dp_replicate` in the MoE state_dict_adapter during checkpoint loading. Root cause: the recipe targets DGX Spark (1 GPU) but CI defaults to NPROC_PER_NODE=8. With 8 GPUs the FSDP2 mesh includes dp_replicate, which the MoE weight dequantization code did not handle. Fixes: - Add `ci.nproc_per_node: 1` to run this recipe on 1 GPU in CI - Add CONFIG_NPROC_PER_NODE support in finetune_launcher.sh and generate_ci_tests.py so per-recipe GPU count overrides work - Skip EP redistribution in state_dict_adapter when no EP dims are present in the DTensor mesh (defensive fix) Verified: 100 steps on 1 GPU, loss 4.90 → 2.25, 61.7 GiB peak memory. Signed-off-by: adil-a <adil.asif2000@hotmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
svcnvidia-nemo-ci
requested review from
HuiyingLi,
adil-a and
akoumpa
as code owners
svcnvidia-nemo-ci
requested review from
ZhiyuLi-Nvidia,
hemildesai and
pthombre
as code owners
Contributor
Author
|
/ok to test f7bdbf5 |
akoumpa
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beep boop [🤖]: Hi @adil-a 👋,