fix(deps): Address container scan vulnerabilities in nemo_toolkit#1740
fix(deps): Address container scan vulnerabilities in nemo_toolkit#1740aryanjsingh wants to merge 1 commit into
Conversation
Greptile SummaryThis PR adds a Key observations:
Confidence Score: 5/5Safe to merge — the change is a single-line, targeted security override that enforces a minimum safe version of nemo_toolkit and is consistent with established project patterns. The change is minimal and surgical: one entry added to an existing override list, alphabetically ordered, with a clear comment tying it to the addressed CVEs. The uv.lock file already resolves nemo-toolkit to 2.7.2, confirming the override is compatible with the current dependency graph. The audio_common extra already required >=2.7.2, so there is no risk of introducing a new incompatible version. No logic, tests, or runtime code is touched. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[uv dependency resolution] --> B{nemo_toolkit requested?}
B -->|direct dep via audio_common| C[nemo_toolkit >= 2.7.2]
B -->|transitive dep any version| D[override-dependencies enforces >= 2.7.2]
C --> E[Resolved: nemo_toolkit 2.7.2]
D --> E
E --> F[GHSA-hvjw-vp7g-39h5 addressed]
E --> G[GHSA-9379-mwvr-7wxx addressed]
Reviews (1): Last reviewed commit: "fix(deps): add override for nemo_toolkit..." | Re-trigger Greptile |
|
Thanks for opening @aryanjsingh . This has already been addressed with #1612 and changes are in the pyproject.toml file already https://github.com/NVIDIA-NeMo/Curator/pull/1740/changes#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R99 |
Summary
This commit resolves security vulnerabilities found in the Curator container scan. It addresses two high-severity issues in
nemo_toolkit(GHSA-hvjw-vp7g-39h5, GHSA-9379-mwvr-7wxx) by adding a dependency override topyproject.toml, ensuring a secure version of the package is installed.Changes
nemo_toolkit>=2.7.2in[tool.uv.override-dependencies]to explicitly enforce the use of a non-vulnerable version, addressing GHSA-hvjw-vp7g-39h5 and GHSA-9379-mwvr-7wxx.Related Issue
Closes #1642