Regenerate uv.lock from prev version from main#1875
Regenerate uv.lock from prev version from main#1875ayushdg merged 5 commits intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
| { url = "https://files.pythonhosted.org/packages/64/a9/156ccd2207fb26b5b61d23728b4dbdc595d1600125aa79683a4a8ddc9313/cbor2-5.7.1-cp312-cp312-win_amd64.whl", hash = "sha256:2d08a6c0d9ed778448e185508d870f4160ba74f59bb17a966abd0d14d0ff4dd3", size = 68404, upload-time = "2025-10-24T09:22:32.108Z" }, | ||
| { url = "https://files.pythonhosted.org/packages/4f/49/adc53615e9dd32c4421f6935dfa2235013532c6e6b28ee515bbdd92618be/cbor2-5.7.1-cp312-cp312-win_arm64.whl", hash = "sha256:752506cfe72da0f4014b468b30191470ee8919a64a0772bd3b36a4fccf5fcefc", size = 64047, upload-time = "2025-10-24T09:22:33.147Z" }, | ||
| { url = "https://files.pythonhosted.org/packages/d5/7d/383bafeabb54c17fe5b6d5aca4e863e6b7df10bcc833b34aa169e9dfce1a/cbor2-5.7.1-py3-none-any.whl", hash = "sha256:68834e4eff2f56629ce6422b0634bc3f74c5a4269de5363f5265fe452c706ba7", size = 23829, upload-time = "2025-10-24T09:23:05.54Z" }, | ||
| version = "5.9.0" |
There was a problem hiding this comment.
@thomasdhc To prevent cases where bad merges, fresh lockfile generation in PRs leading to unrelated dependencies getting downgraded, I'm thinking of adding a GHA that generates a fresh lockfile against main and flagging if it doesn't match the lockfile committed by an Author asking them to regenerate or fix the merge. wdyt?
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
…-uvlock Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Greptile SummaryThis PR adds the
Confidence Score: 4/5Safe to merge; the pyproject.toml change is correct and all version bumps fall within declared constraints, but the nixl 0.10.1→1.0.0 major bump warrants confirmation. The only finding is P2: all bumped packages are within their constraint bounds, but the nixl major-version jump and other unrelated upgrades deserve a quick confirmation that they are intentional before merging. uv.lock — verify that the nixl/nixl-cu12 0.10.1→1.0.0 major bump and the other incidental package upgrades are intentional. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[uv lock regeneration] --> B{platform_machine == x86_64\nand sys_platform != darwin?}
B -- Yes --> C[torchcodec from pytorch index\ndownload.pytorch.org/whl/cu128]
B -- No --> D[torchcodec from PyPI]
C --> E[uv.lock: torchcodec 0.9.1+cu128]
D --> E
E --> F[Side-effect version bumps\ncbor2, lxml-html-clean, meson,\nnixl/nixl-cu12, obstore, onnx,\npillow, pyasn1, pyjwt, pytest,\ntornado, wandb]
Reviews (2): Last reviewed commit: "make torchcodec match the pytorch compat..." | Re-trigger Greptile |
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Description
A previous pr #1679 as a part of the uv.lock update ended up touching dependencies in the lockfile unrelated to the packages added. This PR fixes that by regenerating the lockfile from a previous version from main to avoid the accidental downgrade/upgrade of unrelated packages.
Usage
# Add snippet demonstrating usageChecklist