Fix the Image Curation Tutorial for 0.5.0 release#277
Merged
Conversation
Signed-off-by: Ryan Wolf <rywolf@nvidia.com>
Contributor
Author
|
This one shouldn't be blocked and good to review. |
ryantwolf
changed the title
ayushdg
pushed a commit
to ayushdg/NeMo-Curator
that referenced
this pull request
Oct 30, 2024
Signed-off-by: Ryan Wolf <rywolf@nvidia.com> Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
ayushdg
added a commit
that referenced
this pull request
Nov 4, 2024
* Bump version Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Pin Rapids to 24.8 for 0.5.0 Release (#273) * pin to 24.8 Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * remove nemo_toolkit Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * restrict spacy Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * unrestrict spacy Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * restrict spacy + numpy Signed-off-by: Praateek Mahajan <praateekm@gmail.com> --------- Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * Fix tutorial for release (#277) Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Fix nworkers for tinystories tutorial (#280) Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Pin to 24.8.x instead of 24.8 (#282) Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * Change NSFW Model (#307) * Change download for NSFW model Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Fix model init Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Fix embedding size Signed-off-by: Ryan Wolf <rywolf@nvidia.com> --------- Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Bump version to 0.6.0.dev0 Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * added error handling (#343) Signed-off-by: Tanay Varshney <tvarshney@nvidia.com> --------- Signed-off-by: Ryan Wolf <rywolf@nvidia.com> Signed-off-by: Praateek Mahajan <praateekm@gmail.com> Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: Tanay Varshney <tvarshney@nvidia.com> Co-authored-by: Ryan Wolf <rywolf@nvidia.com> Co-authored-by: Praateek Mahajan <praateekmahajan@users.noreply.github.com> Co-authored-by: Tanay Varshney <varshneytanay@gmail.com>
vinay-raman
pushed a commit
to vinay-raman/NeMo-Curator
that referenced
this pull request
Nov 26, 2024
* Bump version Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Pin Rapids to 24.8 for 0.5.0 Release (NVIDIA-NeMo#273) * pin to 24.8 Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * remove nemo_toolkit Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * restrict spacy Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * unrestrict spacy Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * restrict spacy + numpy Signed-off-by: Praateek Mahajan <praateekm@gmail.com> --------- Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * Fix tutorial for release (NVIDIA-NeMo#277) Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Fix nworkers for tinystories tutorial (NVIDIA-NeMo#280) Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Pin to 24.8.x instead of 24.8 (NVIDIA-NeMo#282) Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * Change NSFW Model (NVIDIA-NeMo#307) * Change download for NSFW model Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Fix model init Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Fix embedding size Signed-off-by: Ryan Wolf <rywolf@nvidia.com> --------- Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Bump version to 0.6.0.dev0 Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * added error handling (NVIDIA-NeMo#343) Signed-off-by: Tanay Varshney <tvarshney@nvidia.com> --------- Signed-off-by: Ryan Wolf <rywolf@nvidia.com> Signed-off-by: Praateek Mahajan <praateekm@gmail.com> Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: Tanay Varshney <tvarshney@nvidia.com> Co-authored-by: Ryan Wolf <rywolf@nvidia.com> Co-authored-by: Praateek Mahajan <praateekmahajan@users.noreply.github.com> Co-authored-by: Tanay Varshney <varshneytanay@gmail.com> Signed-off-by: Vinay Raman <viraman@nvidia.com>
jnke2016
pushed a commit
to jnke2016/Curator
that referenced
this pull request
Nov 12, 2025
* Bump version Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Pin Rapids to 24.8 for 0.5.0 Release (NVIDIA-NeMo#273) * pin to 24.8 Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * remove nemo_toolkit Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * restrict spacy Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * unrestrict spacy Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * restrict spacy + numpy Signed-off-by: Praateek Mahajan <praateekm@gmail.com> --------- Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * Fix tutorial for release (NVIDIA-NeMo#277) Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Fix nworkers for tinystories tutorial (NVIDIA-NeMo#280) Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Pin to 24.8.x instead of 24.8 (NVIDIA-NeMo#282) Signed-off-by: Praateek Mahajan <praateekm@gmail.com> * Change NSFW Model (NVIDIA-NeMo#307) * Change download for NSFW model Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Fix model init Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Fix embedding size Signed-off-by: Ryan Wolf <rywolf@nvidia.com> --------- Signed-off-by: Ryan Wolf <rywolf@nvidia.com> * Bump version to 0.6.0.dev0 Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * added error handling (NVIDIA-NeMo#343) Signed-off-by: Tanay Varshney <tvarshney@nvidia.com> --------- Signed-off-by: Ryan Wolf <rywolf@nvidia.com> Signed-off-by: Praateek Mahajan <praateekm@gmail.com> Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: Tanay Varshney <tvarshney@nvidia.com> Co-authored-by: Ryan Wolf <rywolf@nvidia.com> Co-authored-by: Praateek Mahajan <praateekmahajan@users.noreply.github.com> Co-authored-by: Tanay Varshney <varshneytanay@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the image curation tutorial dependency issues introduced with img2dataset by using our own downloader.
Usage
# Add snippet demonstrating usageChecklist