Fix bugs in retriever sdg notebook #522

vinay-raman · 2025-02-05T18:20:53Z

Description

Fix bugs in retriever sdg notebook.

Checklist

I am familiar with the Contributing Guide.
New or Existing tests cover these changes.
The documentation is up to date with these changes.

Signed-off-by: viraman <viraman@nvidia.com>

Signed-off-by: Vinay Raman <viraman@nvidia.com>

…iraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com>

…dia.com Signed-off-by: Vinay Raman <viraman@nvidia.com>

Signed-off-by: Vinay Raman <viraman@nvidia.com>

nemo_curator/filters/synthetic.py

tutorials/nemo-retriever-synthetic-data-generation/config/config.yaml

ryantwolf · 2025-02-12T21:41:20Z

tutorials/nemo-retriever-synthetic-data-generation/generate.py

+if __name__ == "__main__":
+    dask_client = get_client()
+    main()
+    # dask_client.cancel(dask_client.futures, force=True)


Remove commented out code

It's still there.

ryantwolf · 2025-02-12T21:42:21Z

tutorials/nemo-retriever-synthetic-data-generation/filter.py

What is the difference between this filter.py, generate.py, and main.py? They look nearly identical. They also all look to be CLI scripts but only main.py is mentioned in the README.

README has both generate.py and filter.py mentioned, please have a look.
This is needed if the user just needs to generate data or filter pre-generated data.

Instead of adding two files, can you just add two command line arguments like so?

--generate-only

--filter-only

With two new files, it's very hard to tell if the differences between them are correct or buggy. CLI args in a single file make it much easier to maintain.

resolved, please check the latest commit

I don't see this yet.

ryantwolf · 2025-02-12T21:42:40Z

tutorials/nemo-retriever-synthetic-data-generation/filter.py

+if __name__ == "__main__":
+    dask_client = get_client()
+    main()
+    # dask_client.cancel(dask_client.futures, force=True)


Remove commented out code.

It's still there.

Signed-off-by: viraman <viraman@nvidia.com>

ryantwolf

Two more minor things. Add the two CLI args to main.py instead of two separate files generate.py and filter.py is the big one though.

tutorials/nemo-retriever-synthetic-data-generation/main.py

ryantwolf · 2025-02-13T18:11:52Z

tutorials/nemo-retriever-synthetic-data-generation/notebooks/quickstart.ipynb

     "output_type": "stream",
     "text": [
-      "Generator model used = mistralai/mixtral-8x22b-instruct-v0.1\n"
+      "Generator model used = nvdev/mistralai/mixtral-8x22b-instruct-v0.1\n"


Revert model name.

Signed-off-by: viraman <viraman@nvidia.com>

…Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com>

Signed-off-by: viraman <viraman@nvidia.com>

ryantwolf

@vinay-raman I don't think your changes were pushed or something.

ryantwolf · 2025-02-19T18:08:43Z

tutorials/nemo-retriever-synthetic-data-generation/filter.py

+if __name__ == "__main__":
+    dask_client = get_client()
+    main()
+    # dask_client.cancel(dask_client.futures, force=True)


It's still there.

ryantwolf · 2025-02-19T18:09:04Z

tutorials/nemo-retriever-synthetic-data-generation/generate.py

+if __name__ == "__main__":
+    dask_client = get_client()
+    main()
+    # dask_client.cancel(dask_client.futures, force=True)


It's still there.

ryantwolf · 2025-02-19T18:09:40Z

tutorials/nemo-retriever-synthetic-data-generation/filter.py

I don't see this yet.

Signed-off-by: viraman <viraman@nvidia.com>

* Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * fixed qa bug 5008113, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * bug fixes for generator, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed precommit, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed filters, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed all issues, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed bug with document id, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * check if filtering pipeline is present, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed notebook, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * added functionality to filter pre-generated datasets, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * separated generation & filtering pipelines, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed pre-commit, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * minor changes, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed Ryan Wolf's comments, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * fixed minor bugs in configs, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * removed commented code in main.py, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * added CLI flags for generation & filtering removed code duplication, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * minor fix to quickstart notebook, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * removed filter.py & generate.py, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> --------- Signed-off-by: viraman <viraman@nvidia.com> Signed-off-by: Vinay Raman <viraman@nvidia.com>

* Signed-off by viraman@nvidia.com * Signed-off by viraman@nvidia.com * fixed qa bug 5008113, Signed-off by viraman@nvidia.com * bug fixes for generator, Signed-off by viraman@nvidia.com * fixed precommit, Signed-off by viraman@nvidia.com * fixed filters, Signed-off by viraman@nvidia.com * fixed all issues, Signed-off by viraman@nvidia.com * fixed bug with document id, Signed-off by viraman@nvidia.com * check if filtering pipeline is present, Signed-off by viraman@nvidia.com * fixed notebook, Signed-off by viraman@nvidia.com * added functionality to filter pre-generated datasets, Signed-off by viraman@nvidia.com * separated generation & filtering pipelines, Signed-off by viraman@nvidia.com * fixed pre-commit, Signed-off by viraman@nvidia.com * minor changes, Signed-off by viraman@nvidia.com * fixed Ryan Wolf's comments, Signed-off by viraman@nvidia.com * fixed minor bugs in configs, Signed-off by viraman@nvidia.com * removed commented code in main.py, Signed-off by viraman@nvidia.com * added CLI flags for generation & filtering removed code duplication, Signed-off by viraman@nvidia.com * minor fix to quickstart notebook, Signed-off by viraman@nvidia.com * removed filter.py & generate.py, Signed-off by viraman@nvidia.com --------- Signed-off-by: viraman <viraman@nvidia.com> Signed-off-by: Vinay Raman <viraman@nvidia.com> Co-authored-by: vinay-raman <98057837+vinay-raman@users.noreply.github.com>

* Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * fixed qa bug 5008113, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * bug fixes for generator, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed precommit, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed filters, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed all issues, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed bug with document id, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * check if filtering pipeline is present, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed notebook, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * added functionality to filter pre-generated datasets, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * separated generation & filtering pipelines, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed pre-commit, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * minor changes, Signed-off by viraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com> * fixed Ryan Wolf's comments, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * fixed minor bugs in configs, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * removed commented code in main.py, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * added CLI flags for generation & filtering removed code duplication, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * minor fix to quickstart notebook, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> * removed filter.py & generate.py, Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com> --------- Signed-off-by: viraman <viraman@nvidia.com> Signed-off-by: Vinay Raman <viraman@nvidia.com>

vinay-raman and others added 4 commits February 5, 2025 10:18

Signed-off by viraman@nvidia.com

e5a88c9

Signed-off-by: viraman <viraman@nvidia.com>

Merge branch 'main' into vinayraman/nvbug_5025154_fix

f6a47f9

Signed-off by viraman@nvidia.com

8a6deb9

Signed-off-by: viraman <viraman@nvidia.com>

fixed qa bug 5008113, Signed-off by viraman@nvidia.com

75c869e

Signed-off-by: viraman <viraman@nvidia.com>

ryantwolf changed the title ~~NV bug 5025154 fix~~ Fix bugs in retriever sdg notebook Feb 10, 2025

vinay-raman added 11 commits February 10, 2025 13:33

bug fixes for generator, Signed-off by viraman@nvidia.com

547c849

Signed-off-by: Vinay Raman <viraman@nvidia.com>

fixed precommit, Signed-off by viraman@nvidia.com

cf0ec14

Signed-off-by: Vinay Raman <viraman@nvidia.com>

fixed filters, Signed-off by viraman@nvidia.com

d9f7be3

Signed-off-by: Vinay Raman <viraman@nvidia.com>

fixed all issues, Signed-off by viraman@nvidia.com

d9ee0ee

Signed-off-by: Vinay Raman <viraman@nvidia.com>

fixed bug with document id, Signed-off by viraman@nvidia.com

d892288

Signed-off-by: Vinay Raman <viraman@nvidia.com>

check if filtering pipeline is present, Signed-off by viraman@nvidia.com

9fa6144

Signed-off-by: Vinay Raman <viraman@nvidia.com>

fixed notebook, Signed-off by viraman@nvidia.com

b05f61a

Signed-off-by: Vinay Raman <viraman@nvidia.com>

added functionality to filter pre-generated datasets, Signed-off by v…

2623d0c

…iraman@nvidia.com Signed-off-by: Vinay Raman <viraman@nvidia.com>

separated generation & filtering pipelines, Signed-off by viraman@nvi…

6be54ef

…dia.com Signed-off-by: Vinay Raman <viraman@nvidia.com>

fixed pre-commit, Signed-off by viraman@nvidia.com

49d8eb1

Signed-off-by: Vinay Raman <viraman@nvidia.com>

minor changes, Signed-off by viraman@nvidia.com

6ac6fd9

Signed-off-by: Vinay Raman <viraman@nvidia.com>

ryantwolf suggested changes Feb 12, 2025

View reviewed changes

vinay-raman and others added 2 commits February 12, 2025 17:40

Merge branch 'main' into vinayraman/nvbug_5025154_fix

54e54be

fixed Ryan Wolf's comments, Signed-off by viraman@nvidia.com

0e45f13

Signed-off-by: viraman <viraman@nvidia.com>

ryantwolf suggested changes Feb 13, 2025

View reviewed changes

vinay-raman added 4 commits February 13, 2025 13:30

fixed minor bugs in configs, Signed-off by viraman@nvidia.com

c6609ad

Signed-off-by: viraman <viraman@nvidia.com>

removed commented code in main.py, Signed-off by viraman@nvidia.com

29681f0

Signed-off-by: viraman <viraman@nvidia.com>

added CLI flags for generation & filtering removed code duplication, …

4231843

…Signed-off by viraman@nvidia.com Signed-off-by: viraman <viraman@nvidia.com>

minor fix to quickstart notebook, Signed-off by viraman@nvidia.com

cc1a4e2

Signed-off-by: viraman <viraman@nvidia.com>

ryantwolf suggested changes Feb 19, 2025

View reviewed changes

removed filter.py & generate.py, Signed-off by viraman@nvidia.com

8310324

Signed-off-by: viraman <viraman@nvidia.com>

ryantwolf added the r0.7.0 label Feb 19, 2025

ryantwolf approved these changes Feb 19, 2025

View reviewed changes

ryantwolf merged commit a46fb87 into NVIDIA-NeMo:main Feb 19, 2025
6 checks passed

Fix bugs in retriever sdg notebook #522

Fix bugs in retriever sdg notebook #522

Uh oh!

Conversation

vinay-raman commented Feb 5, 2025 • edited by ryantwolf Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vinay-raman Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryantwolf Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryantwolf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryantwolf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vinay-raman commented Feb 5, 2025 •

edited by ryantwolf

Loading

vinay-raman Feb 13, 2025 •

edited

Loading

ryantwolf Feb 13, 2025 •

edited

Loading

ryantwolf left a comment •

edited

Loading