Add KMeans random_state to semantic deduplication configs
#575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Comment on lines
+69
to
+75
| embedding_column=semdedup_config.embedding_column, | ||
| random_state=semdedup_config.random_state, | ||
| sim_metric=semdedup_config.sim_metric, | ||
| which_to_keep=semdedup_config.which_to_keep, | ||
| sort_clusters=semdedup_config.sort_clusters, | ||
| kmeans_with_cos_dist=semdedup_config.kmeans_with_cos_dist, | ||
| clustering_input_partition_size=semdedup_config.clustering_input_partition_size, |
Contributor
There was a problem hiding this comment.
Thanks for adding these 🙏
I was running the script recently and had to these too
Comment on lines
+168
to
+172
| kmeans = KMeans( | ||
| n_clusters=self.n_clusters, | ||
| max_iter=self.max_iter, | ||
| random_state=self.random_state, | ||
| ) |
Contributor
There was a problem hiding this comment.
Just to confirm this is the main change right?
Contributor
Author
There was a problem hiding this comment.
Yes, everything else is docstring updates or updates to make sure all parameters are being used in the scripts directory. Thanks!
praateekmahajan
approved these changes
Feb 26, 2025
jnke2016
pushed a commit
to jnke2016/Curator
that referenced
this pull request
Nov 12, 2025
…eMo#575) * Add KMeans random_state to semantic deduplication configs Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * edit docstrings Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> --------- Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.