-
Notifications
You must be signed in to change notification settings - Fork 147
fix: cache notebook builds to avoid flaky upstream model failures #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1e96295
fix: cache notebook builds to avoid failures from flaky upstream models
andreatgretel 9a9a56c
fix: address review comments on notebook caching
andreatgretel ea0ed10
fix: only seed cache when truly empty, restore hash writing
andreatgretel 1502732
fix: restrict artifact seed lookup to main branch
andreatgretel 520c160
fix: add actions:read permission for artifact seeding
andreatgretel 632ecbd
fix: only use notebook cache when called from build-docs
andreatgretel c8add33
fix: use jq // empty to avoid "null" string on empty run list
andreatgretel 67101d6
feat: add use_cache input flag to notebook and docs workflows
andreatgretel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| #!/usr/bin/env bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # Build notebooks with per-file caching. Only re-executes notebooks whose | ||
| # source .py file changed since the last cached build. | ||
| # | ||
| # Usage: | ||
| # ./docs/scripts/build_notebooks_cached.sh [CACHE_DIR] | ||
| # | ||
| # CACHE_DIR defaults to .notebook-cache | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| compute_sha256() { | ||
| if command -v sha256sum >/dev/null 2>&1; then | ||
| sha256sum "$1" | cut -d' ' -f1 | ||
| else | ||
| shasum -a 256 "$1" | cut -d' ' -f1 | ||
| fi | ||
| } | ||
|
|
||
| REPO_ROOT="$(cd "$(dirname "$0")/../.." && pwd)" | ||
| SOURCE_DIR="$REPO_ROOT/docs/notebook_source" | ||
| OUTPUT_DIR="$REPO_ROOT/docs/notebooks" | ||
| CACHE_DIR="${1:-$REPO_ROOT/.notebook-cache}" | ||
|
|
||
| mkdir -p "$OUTPUT_DIR" "$CACHE_DIR" | ||
|
|
||
| # Copy static files | ||
| cp "$SOURCE_DIR/_README.md" "$OUTPUT_DIR/README.md" | ||
| cp "$SOURCE_DIR/_pyproject.toml" "$OUTPUT_DIR/pyproject.toml" | ||
|
|
||
| needs_cleanup=false | ||
|
|
||
| for src in "$SOURCE_DIR"/*.py; do | ||
| name="$(basename "$src" .py)" | ||
| hash="$(compute_sha256 "$src")" | ||
| cached_hash_file="$CACHE_DIR/${name}.sha256" | ||
| cached_notebook="$CACHE_DIR/${name}.ipynb" | ||
|
|
||
| if [ -f "$cached_hash_file" ] && [ -f "$cached_notebook" ] && [ "$(cat "$cached_hash_file")" = "$hash" ]; then | ||
| echo " ✅ $name.ipynb — cached (unchanged)" | ||
| cp "$cached_notebook" "$OUTPUT_DIR/${name}.ipynb" | ||
| else | ||
| echo " 🔄 $name.ipynb — executing..." | ||
| uv run --all-packages --group notebooks --group docs jupytext --to ipynb --execute "$src" | ||
| mv "$SOURCE_DIR/${name}.ipynb" "$OUTPUT_DIR/${name}.ipynb" | ||
| needs_cleanup=true | ||
|
|
||
| # Update cache | ||
| cp "$OUTPUT_DIR/${name}.ipynb" "$cached_notebook" | ||
| echo "$hash" > "$cached_hash_file" | ||
| fi | ||
| done | ||
|
|
||
| if [ "$needs_cleanup" = true ]; then | ||
| # Clean up artifacts from executed notebooks | ||
| [ -d "$SOURCE_DIR/artifacts" ] && rm -rf "$SOURCE_DIR/artifacts" | ||
| find "$SOURCE_DIR" -name '*.csv' -delete 2>/dev/null || true | ||
| fi | ||
|
|
||
| echo "✅ Notebooks ready in $OUTPUT_DIR" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.