fix: add chardet<6 constraint to published engine package#406
Merged
johnnygreco merged 2 commits intomainfrom Mar 12, 2026
Merged
fix: add chardet<6 constraint to published engine package#406johnnygreco merged 2 commits intomainfrom
johnnygreco merged 2 commits intomainfrom
Conversation
The workspace-level constraint-dependencies in [tool.uv] is not included in published wheel metadata, so PyPI consumers still get chardet>=6 via sqlfluff, triggering RequestsDependencyWarning from requests<2.33. Move the pin to an explicit dependency in data-designer-engine so it ships with the package.
Now that chardet<6 is an explicit dependency of data-designer-engine, the workspace constraint-dependencies entry is no longer needed.
Contributor
Greptile SummaryThis PR fixes a packaging gap where the The fix correctly moves the constraint from the workspace root into
|
| Filename | Overview |
|---|---|
| packages/data-designer-engine/pyproject.toml | Adds chardet>=3.0.2,<6 as an explicit published dependency to ensure PyPI consumers receive the upper-bound constraint that was previously only in the workspace-level config and never shipped with the wheel. |
| pyproject.toml | Removes the workspace-level constraint-dependencies for chardet (which was never included in published wheel metadata) now that the constraint has been moved into the engine package itself. |
| uv.lock | Lock file regenerated to reflect the moved constraint: workspace-level constraints entry removed, chardet added as an explicit dependency of data-designer-engine at version 5.2.0; lock revision bumped from 3 to 2. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Before["Before (broken for PyPI consumers)"]
A1["workspace pyproject.toml\nconstraint-dependencies:\nchardet>=3.0.2,<6"] -->|NOT exported to wheel metadata| B1["Published wheel\n(no chardet constraint)"]
B1 --> C1["pip install data-designer-engine\n→ sqlfluff pulls chardet>=6\n→ requests<2.33 fires\nRequestsDependencyWarning ⚠️"]
end
subgraph After["After (fix)"]
A2["packages/data-designer-engine/\npyproject.toml\ndependencies: chardet>=3.0.2,<6"] -->|Included in wheel metadata| B2["Published wheel\n(chardet>=3.0.2,<6 constraint)"]
B2 --> C2["pip install data-designer-engine\n→ chardet==5.2.0 resolved\n→ No warning ✅"]
end
Last reviewed commit: 0ea5e76
nabinchha
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
constraint-dependenciesin[tool.uv]is not included in published wheel metadata, so PyPI consumers getchardet>=6(viasqlfluff), triggeringRequestsDependencyWarningfromrequests<2.33chardet>=3.0.2,<6as an explicit dependency ofdata-designer-engineso the constraint ships with the published packageTest plan
data-designer0.5.3rc3 from PyPI in a clean venv —chardet==7.1.0was installed and warning firedchardet==5.2.0was installed and no warning