feat: add preview review reference and update interactive iterate step#441
Merged
johnnygreco merged 14 commits intomainfrom Mar 23, 2026
Merged
feat: add preview review reference and update interactive iterate step#441johnnygreco merged 14 commits intomainfrom
johnnygreco merged 14 commits intomainfrom
Conversation
Contributor
Greptile SummaryThis PR adds a new Key points:
|
| Filename | Overview |
|---|---|
| skills/data-designer/references/preview-review.md | New guide providing structured review criteria (diversity, data quality, design choices). Instructs agents to load dataset.parquet, but the file's existence from --save-results is undocumented; fallback glob artifacts/preview_results_*/ also lacks guidance on how to resolve "most recent". |
| skills/data-designer/workflows/interactive.md | Iterate step expanded to offer self-review via references/preview-review.md; stale "serve again" wording removed; finalize caution generalized from hard-coded 50-record threshold. Path references/preview-review.md may not resolve correctly relative to this file's location. |
| skills/data-designer/workflows/autopilot.md | Create step reworded to remove the 50-record hard threshold in favor of context-sensitive guidance; however, the instruction still directs the agent to run the command first and warn/confirm "before running" second — a contradictory ordering that was flagged in a prior review thread and remains unresolved. |
Sequence Diagram
sequenceDiagram
participant U as User
participant A as Agent
participant DD as data-designer CLI
participant PR as preview-review.md
Note over A,DD: Interactive Workflow — Iterate Step (updated)
DD-->>A: Results path: artifacts/preview_results_*/
A->>U: Here is your preview link
A->>U: Would you like me to review the records?
alt User accepts self-review
A->>PR: Read references/preview-review.md
PR-->>A: Diversity / Quality / Design criteria
A->>DD: Load dataset.parquet (pandas)
DD-->>A: Sample records
A->>A: Evaluate diversity, quality, design
A->>U: Suggested improvements
else User provides own feedback
U->>A: Feedback
end
A->>DD: data-designer validate + preview
DD-->>A: Updated preview
A->>U: Repeat until satisfied
Prompt To Fix All With AI
This is a comment left during a code review.
Path: skills/data-designer/references/preview-review.md
Line: 9
Comment:
**"Most recent" directory is ambiguous for an agent**
The fallback path `artifacts/preview_results_*/` is a glob that can match multiple directories. The guide says to use "the most recent" one, but does not explain how to determine recency — by modification time, by directory name suffix, or by listing and sorting. An agent may arbitrarily pick any match.
Consider making this explicit, e.g.:
```suggestion
Load `dataset.parquet` from the preview results directory (printed as `Results path:` by the preview command, or the most recent `artifacts/preview_results_*/` directory — sort by name or modification time to find it).
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (9): Last reviewed commit: "Merge branch 'main' into feat/skill-prev..." | Re-trigger Greptile
nabinchha
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
references/preview-review.mdwith structured guidance for reviewing dataset previews (diversity, data quality, design choices)