Publish packages from GitHub releases#37
Merged
Conversation
johnnygreco
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move plugin package publication from tag-push events to explicit GitHub Release publication events.
The publish workflow now runs when a GitHub Release is published, gates the job to release tags shaped like
data-designer-*/vX.Y.Z, validates the exact<plugin-package>/vX.Y.Zsemver shape, checks out the release tag, and keeps the existing package validation/build/upload/Page deploy flow.It also removes the custom CODEOWNERS membership check from the publish job. Publishing the GitHub Release is now the maintainer authorization boundary, so team CODEOWNER membership does not have to be reimplemented with a token that can read org membership.
Why
The previous tag-push workflow failed for team CODEOWNERS because
GITHUB_TOKENcannot reliably resolve org team membership. That made the custom guard weaker than the actual GitHub permission model and blocked valid releases by members of CODEOWNER teams.Using an explicit GitHub Release event gives us a clearer release action and avoids duplicating GitHub's CODEOWNER/team authorization logic in shell.
Usage
After
make releasecreates the tag:For the already-pushed
data-designer-retrieval-sdg/v0.1.0tag, once this lands onmain, publishing that GitHub Release should trigger the package publish workflow.Validation
.github/workflows/publish.ymlwith PyYAML and asserted the release trigger and removed CODEOWNERS step.make docsmake check