Add apply_chat_template to HF vllm Ray deployment#581
Merged
Conversation
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Contributor
Author
|
/ok to test 1c76096 |
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Contributor
Author
|
/ok to test db80f60 |
oyilmaz-nvidia
approved these changes
Feb 4, 2026
Contributor
Author
|
/ok to test b1876c3 |
ko3n1g
pushed a commit
that referenced
this pull request
Feb 4, 2026
Signed-off-by: Abhishree <abhishreetm@gmail.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#575 missed to add apply_chat_template functionality explicitly to ray_infer_fn in vLLMExporter class which led to incorrect eval accuracy on chat benchmarks for HF deployment with Ray via vllm backend. This PR fixes it.