Skip to content

ci: Re-enable onnx test#597

Merged
oyilmaz-nvidia merged 12 commits intomainfrom
chtruong/onnx-override
Feb 14, 2026
Merged

ci: Re-enable onnx test#597
oyilmaz-nvidia merged 12 commits intomainfrom
chtruong/onnx-override

Conversation

@chtruong814
Copy link
Contributor

@chtruong814 chtruong814 commented Feb 12, 2026

ci: Re-enable onnx test

The onnx export only works with an older transformers. We'll enable it again and communicate via docs update that this is what is necessary for onnx export.

The onnx quantize export was failing with this error:

   File "/usr/local/lib/python3.12/dist-packages/torch/export/_trace.py", line 2122, in _export_for_training
      raise RuntimeError(error_msg)
  RuntimeError: We found a fake tensor in the exported program constant's list. This typically means our tracing system encountered an op that we can't trace through. For the potential source, you can refer to following model attribute: model.layers.0.self_attn.q_proj.input_quantizer.lifted_tensor_0. Please file an issue on github. 

I updated the export code to be similar to how modelopt is handling it. It seems that they default to dynamo=false?:
https://github.com/NVIDIA/Model-Optimizer/blob/main/modelopt/torch/_deploy/utils/torch_onnx.py#L527

tbh, unsure what should be appropriate there

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
This reverts commit c119095.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@oyilmaz-nvidia oyilmaz-nvidia enabled auto-merge (squash) February 14, 2026 00:25
@chtruong814 chtruong814 added the r0.4.0 Cherry-pick PR to r0.4.0 release branch label Feb 14, 2026
@oyilmaz-nvidia oyilmaz-nvidia merged commit 7b7a7c2 into main Feb 14, 2026
45 of 47 checks passed
@oyilmaz-nvidia oyilmaz-nvidia deleted the chtruong/onnx-override branch February 14, 2026 00:30
chtruong814 added a commit that referenced this pull request Feb 14, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814 added a commit that referenced this pull request Feb 15, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI documentation Improvements or additions to documentation export ONNX r0.4.0 Cherry-pick PR to r0.4.0 release branch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants