Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
This reverts commit c119095. Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
oyilmaz-nvidia
approved these changes
Feb 14, 2026
oyilmaz-nvidia
approved these changes
Feb 14, 2026
ko3n1g
approved these changes
Feb 14, 2026
chtruong814
added a commit
that referenced
this pull request
Feb 14, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814
added a commit
that referenced
this pull request
Feb 15, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: Re-enable onnx test
The onnx export only works with an older transformers. We'll enable it again and communicate via docs update that this is what is necessary for onnx export.
The onnx quantize export was failing with this error:
I updated the export code to be similar to how modelopt is handling it. It seems that they default to
dynamo=false?:https://github.com/NVIDIA/Model-Optimizer/blob/main/modelopt/torch/_deploy/utils/torch_onnx.py#L527
tbh, unsure what should be appropriate there