ci: build container once and share across downstream tests#661
Merged
Conversation
Instead of having each test job build its own container, add a cicd-container-build job that builds a single inframework base image, pushes it to ECR, and all downstream tests pull that image. Each test then runs `uv sync --extra <framework>` to install its specific inference framework deps at runtime. Also hardcodes runner prefixes/paths/registries in pre-flight config (matching NeMo-LM pattern) and removes Azure credential plumbing since we're using AWS H100 runners exclusively. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814
force-pushed
the
chtruong/container-test
branch
from
2e5388b to
d12cb14
Compare
Contributor
Author
|
/ok to test d12cb14 |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Contributor
Author
|
/ok to test f9009c0 |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Contributor
Author
|
/ok to test e25cdfc |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Contributor
Author
|
/ok to test 9eabc10 |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Contributor
Author
|
/ok to test 84327c7 |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Contributor
Author
|
/ok to test a670fee |
ko3n1g
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cicd-container-buildjob that builds a singleinframeworkbase container image and pushes it to ECR (evaluator:<sha>)uv sync --extra <framework>to install framework-specific deps at runtimeTest plan
cicd-container-buildjob builds and pushes to ECR successfully🤖 Generated with Claude Code