Fix tokenizer issue with chat template#697
Merged
Merged
Conversation
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
oyilmaz-nvidia
requested review from
athitten,
meatybobby and
pthombre
as code owners
Contributor
Author
|
/ok to test 3ccd108 |
athitten
approved these changes
May 28, 2026
Contributor
athitten
left a comment
athitten
left a comment
There was a problem hiding this comment.
LG, thank you @oyilmaz-nvidia !
Contributor
|
Might be good to add 1 or 2 test for this @oyilmaz-nvidia , also code cov is low |
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Contributor
Author
|
/ok to test 307a32f |
Contributor
Author
|
/ok to test 9b6d6b3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.