fix(deps): restrict pytest-asyncio to <1.0.0 #1215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit pytest-asyncio version to below 1.0.0 to avoid breaking changes introduced in major releases 1.0.0 released on May 26. Update poetry.lock content hash accordingly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1215 +/- ##
========================================
Coverage 68.65% 68.65%
========================================
Files 161 161
Lines 15978 15978
========================================
Hits 10969 10969
Misses 5009 5009
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
cparisien
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit pytest-asyncio version to below 1.0.0 to avoid breaking changes introduced in major release 1.0.0, released on May 26. Update poetry.lock content hash accordingly.
Fixes:
https://github.com/NVIDIA/NeMo-Guardrails/actions/workflows/latest-deps-tests.yml
including:
❌ https://github.com/NVIDIA/NeMo-Guardrails/actions/runs/15334510137
❌ https://github.com/NVIDIA/NeMo-Guardrails/actions/runs/15311531025
❌ https://github.com/NVIDIA/NeMo-Guardrails/actions/runs/15262598796
Fixed:
✅ green again: https://github.com/NVIDIA/NeMo-Guardrails/actions/runs/15341144860