Differentiate Example-only and Training Resource Servers#264
Merged
bxyu-nvidia merged 15 commits intomainfrom Nov 5, 2025
Merged
Differentiate Example-only and Training Resource Servers#264bxyu-nvidia merged 15 commits intomainfrom
bxyu-nvidia merged 15 commits intomainfrom
Conversation
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
fsiino-nvidia
changed the title
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
…ce-server-organization Signed-off-by: Frankie Siino <fsiino@nvidia.com> # Conflicts: # README.md
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
…ce-server-organization Signed-off-by: Frankie Siino <fsiino@nvidia.com> # Conflicts: # README.md
bxyu-nvidia
requested changes
Nov 5, 2025
| self._dir_path = Path(self.entrypoint) | ||
| assert not self.dir_path.is_absolute() | ||
| assert len(self.dir_path.parts) == 2 | ||
| assert len(self.dir_path.parts) >= 2 |
Contributor
There was a problem hiding this comment.
can we revert this back to ==?
|
|
||
| dirpath = Path(run_config.entrypoint) | ||
| assert len(dirpath.parts) == 2 | ||
| assert len(dirpath.parts) >= 2 |
| [tool.setuptools.packages.find] | ||
| where = ["."] | ||
| include = ["resources_servers", "responses_api_agents", "responses_api_models", "nemo_gym", "penguin"] | ||
| include = ["resources_servers", "resources_servers.examples","responses_api_agents", "responses_api_models", "nemo_gym", "penguin"] |
Signed-off-by: Frankie Siino <fsiino@nvidia.com>
bxyu-nvidia
approved these changes
Nov 5, 2025
Kelvin0110
pushed a commit
to Kelvin0110/Gym
that referenced
this pull request
Feb 16, 2026
…#264) This PR changes the file structure of the `resources_servers/` folder to place example-only servers in the `/examples` subdirectory. It also changes the tables in the README to more clearly distinguish these servers. --------- Signed-off-by: Frankie Siino <fsiino@nvidia.com>
abubakaria56
pushed a commit
to abubakaria56/Gym
that referenced
this pull request
Mar 2, 2026
…#264) This PR changes the file structure of the `resources_servers/` folder to place example-only servers in the `/examples` subdirectory. It also changes the tables in the README to more clearly distinguish these servers. --------- Signed-off-by: Frankie Siino <fsiino@nvidia.com>
abubakaria56
pushed a commit
to abubakaria56/Gym
that referenced
this pull request
Mar 2, 2026
…#264) This PR changes the file structure of the `resources_servers/` folder to place example-only servers in the `/examples` subdirectory. It also changes the tables in the README to more clearly distinguish these servers. --------- Signed-off-by: Frankie Siino <fsiino@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the file structure of the
resources_servers/folder to place example-only servers in the/examplessubdirectory. It also changes the tables in the README to more clearly distinguish these servers.