Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
cmunley1
force-pushed
the
cmunley1/pypi-compat
branch
from
56fc579 to
e4e9c9e
Compare
cmunley1
commented
Feb 10, 2026
cmunley1
commented
Feb 10, 2026
cmunley1
commented
Feb 10, 2026
Contributor
Author
|
to test: |
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
bxyu-nvidia
approved these changes
Mar 6, 2026
5 tasks
gwarmstrong
pushed a commit
that referenced
this pull request
Mar 9, 2026
- search cwd for `env.yaml` and for config paths provided to `ng_run`. - use `importlib.metadata` for `ng_help` - modify server requirements.txt or pyproject.toml to use pypi nemo-gym rather than ../../ relative path basic tests done of `ng_run` and `ng_collect_rollouts` with an environment outside of `Gym/`. I think that we should really consider a few things, but maybe we stick to minimal changes for now: - packaging environments separately - moving resources_servers etc inside nemo_gym to have only 1 entrypoint in sitepackages, i find it strange to have `site-packages/resources_servers` - giving user clear guidance on proper way to make new env with pip installed gym. Mocking Gym repo structure is 1 option --------- Signed-off-by: Christian Munley <cmunley@nvidia.com> Signed-off-by: cmunley1 <cmunley@nvidia.com> Signed-off-by: George Armstrong <georgea@nvidia.com>
vadam5
pushed a commit
that referenced
this pull request
Mar 10, 2026
- search cwd for `env.yaml` and for config paths provided to `ng_run`. - use `importlib.metadata` for `ng_help` - modify server requirements.txt or pyproject.toml to use pypi nemo-gym rather than ../../ relative path basic tests done of `ng_run` and `ng_collect_rollouts` with an environment outside of `Gym/`. I think that we should really consider a few things, but maybe we stick to minimal changes for now: - packaging environments separately - moving resources_servers etc inside nemo_gym to have only 1 entrypoint in sitepackages, i find it strange to have `site-packages/resources_servers` - giving user clear guidance on proper way to make new env with pip installed gym. Mocking Gym repo structure is 1 option --------- Signed-off-by: Christian Munley <cmunley@nvidia.com> Signed-off-by: cmunley1 <cmunley@nvidia.com> Signed-off-by: George Armstrong <georgea@nvidia.com>
MahanFathi
pushed a commit
that referenced
this pull request
Mar 24, 2026
- search cwd for `env.yaml` and for config paths provided to `ng_run`. - use `importlib.metadata` for `ng_help` - modify server requirements.txt or pyproject.toml to use pypi nemo-gym rather than ../../ relative path basic tests done of `ng_run` and `ng_collect_rollouts` with an environment outside of `Gym/`. I think that we should really consider a few things, but maybe we stick to minimal changes for now: - packaging environments separately - moving resources_servers etc inside nemo_gym to have only 1 entrypoint in sitepackages, i find it strange to have `site-packages/resources_servers` - giving user clear guidance on proper way to make new env with pip installed gym. Mocking Gym repo structure is 1 option --------- Signed-off-by: Christian Munley <cmunley@nvidia.com> Signed-off-by: cmunley1 <cmunley@nvidia.com>
jsw-zorro
pushed a commit
to niletron/Gym
that referenced
this pull request
Apr 7, 2026
- search cwd for `env.yaml` and for config paths provided to `ng_run`. - use `importlib.metadata` for `ng_help` - modify server requirements.txt or pyproject.toml to use pypi nemo-gym rather than ../../ relative path basic tests done of `ng_run` and `ng_collect_rollouts` with an environment outside of `Gym/`. I think that we should really consider a few things, but maybe we stick to minimal changes for now: - packaging environments separately - moving resources_servers etc inside nemo_gym to have only 1 entrypoint in sitepackages, i find it strange to have `site-packages/resources_servers` - giving user clear guidance on proper way to make new env with pip installed gym. Mocking Gym repo structure is 1 option --------- Signed-off-by: Christian Munley <cmunley@nvidia.com> Signed-off-by: cmunley1 <cmunley@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
env.yamland for config paths provided tong_run.importlib.metadataforng_helpbasic tests done of
ng_runandng_collect_rolloutswith an environment outside ofGym/.I think that we should really consider a few things, but maybe we stick to minimal changes for now:
site-packages/resources_servers