fix: ng prepare data metrics conflict#738
Merged
bxyu-nvidia merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
Signed-off-by: cmunley1 <cmunley@nvidia.com>
bxyu-nvidia
approved these changes
Feb 24, 2026
fsiino-nvidia
pushed a commit
that referenced
this pull request
Feb 26, 2026
issue described in #736 collate_samples writes metrics without the dataset config metadata eg name type jsonl_fpath while validate_samples_and_aggregate_emtrics wrote those with metadata , causing a conflict. this mirrors what the validate step does to merge the metadata before the conflict check Signed-off-by: cmunley1 <cmunley@nvidia.com>
fsiino-nvidia
pushed a commit
that referenced
this pull request
Feb 26, 2026
issue described in #736 collate_samples writes metrics without the dataset config metadata eg name type jsonl_fpath while validate_samples_and_aggregate_emtrics wrote those with metadata , causing a conflict. this mirrors what the validate step does to merge the metadata before the conflict check Signed-off-by: cmunley1 <cmunley@nvidia.com>
abubakaria56
pushed a commit
to abubakaria56/Gym
that referenced
this pull request
Mar 2, 2026
issue described in NVIDIA-NeMo#736 collate_samples writes metrics without the dataset config metadata eg name type jsonl_fpath while validate_samples_and_aggregate_emtrics wrote those with metadata , causing a conflict. this mirrors what the validate step does to merge the metadata before the conflict check Signed-off-by: cmunley1 <cmunley@nvidia.com>
abubakaria56
pushed a commit
to abubakaria56/Gym
that referenced
this pull request
Mar 2, 2026
issue described in NVIDIA-NeMo#736 collate_samples writes metrics without the dataset config metadata eg name type jsonl_fpath while validate_samples_and_aggregate_emtrics wrote those with metadata , causing a conflict. this mirrors what the validate step does to merge the metadata before the conflict check Signed-off-by: cmunley1 <cmunley@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue described in #736
collate_samples writes metrics without the dataset config metadata eg name type jsonl_fpath while validate_samples_and_aggregate_emtrics wrote those with metadata , causing a conflict. this mirrors what the validate step does to merge the metadata before the conflict check