[fix] (code_gen): use runtime_env py_executable for Ray workers#913
Merged
bxyu-nvidia merged 3 commits intoNVIDIA-NeMo:mainfrom Mar 20, 2026
Merged
[fix] (code_gen): use runtime_env py_executable for Ray workers#913bxyu-nvidia merged 3 commits intoNVIDIA-NeMo:mainfrom
bxyu-nvidia merged 3 commits intoNVIDIA-NeMo:mainfrom
Conversation
Contributor
|
PR looks great, can you please help to resolve the failing DCO please? |
Signed-off-by: spacegoing <spacegoing@gmail.com>
Signed-off-by: spacegoing <spacegoing@gmail.com>
Contributor
Author
|
@bxyu-nvidia DCO fixed. |
Contributor
|
Sorry I should have kicked off the linting job earlier so you didn't have to do 2 rounds of iterations 🤦 can you pls do the pre-commit steps here to fix the linting https://github.com/NVIDIA-NeMo/Gym?tab=contributing-ov-file#development-setup |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: spacegoing <spacegoing@gmail.com>
Contributor
Author
|
@bxyu-nvidia no worries, lint fixed and pushed again |
bxyu-nvidia
approved these changes
Mar 20, 2026
MahanFathi
pushed a commit
that referenced
this pull request
Mar 24, 2026
`check_correctness_remote` was decorated with `@ray.remote` without
`runtime_env`, so Ray workers spawned on system Python could not import
`lcb_integration`. The workaround was a symlink from the server's venv
into `/usr/local/lib/python3.12/dist-packages/`.
Fix: add `runtime_env={"py_executable": sys.executable}` to the
decorator, consistent with the pattern already used in `swe_agents`,
`mini_swe_agent`, and `harbor_agent`.
This ensures Ray workers inherit the code_gen server's venv and can
import `lcb_integration` directly, with no system path side effects.
---------
Signed-off-by: spacegoing <spacegoing@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jsw-zorro
pushed a commit
to niletron/Gym
that referenced
this pull request
Apr 7, 2026
…IA-NeMo#913) `check_correctness_remote` was decorated with `@ray.remote` without `runtime_env`, so Ray workers spawned on system Python could not import `lcb_integration`. The workaround was a symlink from the server's venv into `/usr/local/lib/python3.12/dist-packages/`. Fix: add `runtime_env={"py_executable": sys.executable}` to the decorator, consistent with the pattern already used in `swe_agents`, `mini_swe_agent`, and `harbor_agent`. This ensures Ray workers inherit the code_gen server's venv and can import `lcb_integration` directly, with no system path side effects. --------- Signed-off-by: spacegoing <spacegoing@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_correctness_remotewas decorated with@ray.remotewithoutruntime_env, so Ray workers spawned on system Python could not importlcb_integration. The workaround was a symlink from the server's venvinto
/usr/local/lib/python3.12/dist-packages/.Fix: add
runtime_env={"py_executable": sys.executable}to thedecorator, consistent with the pattern already used in
swe_agents,mini_swe_agent, andharbor_agent.This ensures Ray workers inherit the code_gen server's venv and can
import
lcb_integrationdirectly, with no system path side effects.