[Fix] use venv Python for swerl_gen Ray workers instead of hardcoded PYTHONPATH#920
Merged
bxyu-nvidia merged 1 commit intoNVIDIA-NeMo:mainfrom Mar 20, 2026
Merged
Conversation
…PYTHONPATH Signed-off-by: spacegoing <spacegoing@gmail.com>
bxyu-nvidia
approved these changes
Mar 20, 2026
MahanFathi
pushed a commit
that referenced
this pull request
Mar 24, 2026
…PYTHONPATH (#920) ## Fix: use venv Python for swerl_gen Ray workers Replace the hardcoded `PYTHONPATH="/opt/nemo-rl/3rdparty/Gym-workspace/Gym"` in `singularity_utils.py` with `py_executable: sys.executable`. ### Problem The `compute_score` Ray remote task hardcodes an internal deployment path in its `runtime_env`. This breaks any setup where Gym is installed at a different location. ### Fix Set `py_executable: sys.executable` so Ray workers use the same venv Python as the server process. Since `nemo_gym` is installed as an editable package and `resources_servers` is included in `pyproject.toml`'s package list, all imports resolve correctly from the venv — no `PYTHONPATH` override needed. This is the same pattern applied to `compute_code_generation_metrics.py` in #908. Signed-off-by: spacegoing <spacegoing@gmail.com>
jsw-zorro
pushed a commit
to niletron/Gym
that referenced
this pull request
Apr 7, 2026
…PYTHONPATH (NVIDIA-NeMo#920) ## Fix: use venv Python for swerl_gen Ray workers Replace the hardcoded `PYTHONPATH="/opt/nemo-rl/3rdparty/Gym-workspace/Gym"` in `singularity_utils.py` with `py_executable: sys.executable`. ### Problem The `compute_score` Ray remote task hardcodes an internal deployment path in its `runtime_env`. This breaks any setup where Gym is installed at a different location. ### Fix Set `py_executable: sys.executable` so Ray workers use the same venv Python as the server process. Since `nemo_gym` is installed as an editable package and `resources_servers` is included in `pyproject.toml`'s package list, all imports resolve correctly from the venv — no `PYTHONPATH` override needed. This is the same pattern applied to `compute_code_generation_metrics.py` in NVIDIA-NeMo#908. Signed-off-by: spacegoing <spacegoing@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: use venv Python for swerl_gen Ray workers
Replace the hardcoded
PYTHONPATH="/opt/nemo-rl/3rdparty/Gym-workspace/Gym"insingularity_utils.pywithpy_executable: sys.executable.Problem
The
compute_scoreRay remote task hardcodes an internal deployment path in itsruntime_env. This breaks any setup where Gym is installed at a different location.Fix
Set
py_executable: sys.executableso Ray workers use the same venv Python as the server process. Sincenemo_gymis installed as an editable package andresources_serversis included inpyproject.toml's package list, all imports resolve correctly from the venv — noPYTHONPATHoverride needed.This is the same pattern applied to
compute_code_generation_metrics.pyin #908.