Do not load context for model transform in llm inference#11751
Merged
hemildesai merged 3 commits intomainfrom Jan 14, 2025
Merged
Do not load context for model transform in llm inference#11751hemildesai merged 3 commits intomainfrom
hemildesai merged 3 commits intomainfrom
Conversation
shanmugamr1992
previously approved these changes
Jan 3, 2025
Signed-off-by: Hemil Desai <hemild@nvidia.com>
hemildesai
force-pushed
the
hemil/peft-inference-fix
branch
from
1da1fc6 to
ec604bd
Compare
Contributor
|
[🤖]: Hi @hemildesai 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
cuichenx
reviewed
Jan 8, 2025
Collaborator
cuichenx
left a comment
cuichenx
left a comment
There was a problem hiding this comment.
Thanks for the optimization! Suggestion below on updating the type annotation
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Contributor
|
[🤖]: Hi @hemildesai 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
abhinavg4
pushed a commit
that referenced
this pull request
Jan 30, 2025
Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
youngeunkwon0405
pushed a commit
to youngeunkwon0405/NeMo
that referenced
this pull request
Feb 10, 2025
…#11751) Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.