Skip to content

LinearAdapter: propagate args to _init_adapter#11902

Merged
akoumpa merged 3 commits intomainfrom
akoumparouli/fix_lora
Jan 20, 2025
Merged

LinearAdapter: propagate args to _init_adapter#11902
akoumpa merged 3 commits intomainfrom
akoumparouli/fix_lora

Conversation

@akoumpa
Copy link
Collaborator

@akoumpa akoumpa commented Jan 20, 2025

What does this PR do ?

Changes:

  1. pass params from LinearAdapter's constructor to LinearAdapter._init_adapter -> previously was using _init_adapter's default values
  2. switch from dropout 0 to 0.1
    Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/fix_lora branch from 830a84f to fc69ce2 Compare January 20, 2025 18:44
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
@github-actions
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.llm.peft.lora
nemo/collections/llm/peft/lora.py:158:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.90/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

@akoumpa akoumpa changed the title propagate defaults LinearAdapter: propagate args to _init_adapter Jan 20, 2025
@akoumpa akoumpa requested a review from marcromeyn January 20, 2025 19:59
@akoumpa akoumpa marked this pull request as ready for review January 20, 2025 20:00
@github-actions
Copy link
Contributor

[🤖]: Hi @akoumpa 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@akoumpa akoumpa merged commit 499161e into main Jan 20, 2025
206 of 210 checks passed
@akoumpa akoumpa deleted the akoumparouli/fix_lora branch January 20, 2025 23:17
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
* propagate defaults

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* switch dropout default to 0.0

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* propagate defaults

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* switch dropout default to 0.0

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants