Skip to content

[Audio] Fix extra step in Euler sampler for flow matching inference#11989

Merged
racoiaws merged 4 commits intoNVIDIA-NeMo:mainfrom
racoiaws:dev/flowmatching_time_nsteps
Feb 3, 2025
Merged

[Audio] Fix extra step in Euler sampler for flow matching inference#11989
racoiaws merged 4 commits intoNVIDIA-NeMo:mainfrom
racoiaws:dev/flowmatching_time_nsteps

Conversation

@racoiaws
Copy link
Collaborator

What does this PR do ?

This PR fixes number of function evaluations / steps in flow matching Euler sampler, changing it from num_steps + 1 to intended num_steps.

This PR also adds a test that checks number estimator.forward calls inside a single sampler call.

Collection: Audio

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to #10052, only affects inference, not training

Signed-off-by: Roman Korostik <rkorostik@nvidia.com>
Signed-off-by: Roman Korostik <rkorostik@nvidia.com>
@racoiaws racoiaws requested a review from anteju January 29, 2025 17:15
@racoiaws racoiaws self-assigned this Jan 29, 2025
@github-actions github-actions bot added the audio label Jan 29, 2025
Signed-off-by: racoiaws <racoiaws@users.noreply.github.com>
@racoiaws racoiaws added Run CICD and removed Run CICD labels Feb 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.audio.parts.submodules.flow
nemo/collections/audio/parts/submodules/flow.py:192:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/audio/parts/submodules/flow.py:196:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.77/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

@racoiaws racoiaws merged commit 48f10af into NVIDIA-NeMo:main Feb 3, 2025
212 of 214 checks passed
BoxiangW pushed a commit that referenced this pull request Feb 7, 2025
…11989)

* Fix number of steps in Euler sampler for flow matching audio models

Signed-off-by: Roman Korostik <rkorostik@nvidia.com>

* Test for NFE in Euler sampler for flow matching audio models

Signed-off-by: Roman Korostik <rkorostik@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: Roman Korostik <racoiaws@users.noreply.github.com>

---------

Signed-off-by: Roman Korostik <rkorostik@nvidia.com>
Signed-off-by: Roman Korostik <racoiaws@users.noreply.github.com>
Co-authored-by: Roman Korostik <racoiaws@users.noreply.github.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
…VIDIA-NeMo#11989)

* Fix number of steps in Euler sampler for flow matching audio models

Signed-off-by: Roman Korostik <rkorostik@nvidia.com>

* Test for NFE in Euler sampler for flow matching audio models

Signed-off-by: Roman Korostik <rkorostik@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: Roman Korostik <racoiaws@users.noreply.github.com>

---------

Signed-off-by: Roman Korostik <rkorostik@nvidia.com>
Signed-off-by: Roman Korostik <racoiaws@users.noreply.github.com>
Co-authored-by: Roman Korostik <racoiaws@users.noreply.github.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants