nemo automodel sft squad data prep fix by akoumpa · Pull Request #11994 · NVIDIA-NeMo/NeMo

akoumpa · 2025-01-30T00:20:44Z

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

examples/llm/peft/hf.py

nemo/collections/llm/gpt/data/hf_dataset.py

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

examples/llm/peft/hf.py

examples/llm/sft/hf.py

Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>

github-actions · 2025-01-30T03:41:39Z

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.

Your code was analyzed with PyLint. The following annotations have been identified:

************* Module hf
examples/llm/peft/hf.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.collections.llm.gpt.data.hf_dataset
nemo/collections/llm/gpt/data/hf_dataset.py:24:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:178:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:183:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:208:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:234:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:238:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:242:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:248:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:254:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:268:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/gpt/data/hf_dataset.py:273:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.39/10

Mitigation guide:

Add sensible and useful docstrings to functions and methods
For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

github-actions · 2025-01-30T08:36:52Z

[🤖]: Hi @akoumpa 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

* use pad_token_id= 0 if padding loss_mask; update squad dataset Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * update LLM peft/sft scripts + FSDP2 strategy Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> * Update hf.py Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> * Update hf.py Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> * Update hf.py Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> * Update hf.py Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>

* use pad_token_id= 0 if padding loss_mask; update squad dataset Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * update LLM peft/sft scripts + FSDP2 strategy Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> * Update hf.py Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> * Update hf.py Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> * Update hf.py Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> * Update hf.py Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>

akoumpa added 2 commits January 29, 2025 16:04

use pad_token_id= 0 if padding loss_mask; update squad dataset

95da196

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

update LLM peft/sft scripts + FSDP2 strategy

e86909b

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

akoumpa force-pushed the akoumparouli/nemo_automodel_sft_squad_fix branch from 62d3c6f to e86909b Compare January 30, 2025 00:21

github-advanced-security bot found potential problems Jan 30, 2025

View reviewed changes

examples/llm/peft/hf.py Fixed Show fixed Hide fixed

nemo/collections/llm/gpt/data/hf_dataset.py Fixed Show fixed Hide fixed

akoumpa added 2 commits January 29, 2025 17:18

fix

9750b98

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

fix

527e553

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

akoumpa force-pushed the akoumparouli/nemo_automodel_sft_squad_fix branch from 315eb39 to 527e553 Compare January 30, 2025 01:21

fix

d2d4db1

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

akoumpa force-pushed the akoumparouli/nemo_automodel_sft_squad_fix branch from 65e70c4 to d2d4db1 Compare January 30, 2025 01:23

fix

080256a

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

akoumpa force-pushed the akoumparouli/nemo_automodel_sft_squad_fix branch from 6da7269 to 080256a Compare January 30, 2025 01:30

Apply isort and black reformatting

0d8785a

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

github-advanced-security bot found potential problems Jan 30, 2025

View reviewed changes

examples/llm/peft/hf.py Fixed Show fixed Hide fixed

examples/llm/sft/hf.py Fixed Show fixed Hide fixed

akoumpa changed the title ~~Akoumparouli/nemo automodel sft squad fix~~ nemo automodel sft squad data prep fix Jan 30, 2025

akoumpa added 4 commits January 29, 2025 18:02

Update hf.py

66db4d4

Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>

Update hf.py

42f70ec

Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>

Update hf.py

2e48c98

Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>

Update hf.py

b93478e

Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>

akoumpa added the Run CICD label Jan 30, 2025

akoumpa marked this pull request as ready for review January 30, 2025 17:21

yuanzhedong approved these changes Jan 30, 2025

View reviewed changes

akoumpa merged commit ea5ed67 into main Jan 30, 2025
210 of 212 checks passed

akoumpa deleted the akoumparouli/nemo_automodel_sft_squad_fix branch January 30, 2025 17:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nemo automodel sft squad data prep fix#11994

nemo automodel sft squad data prep fix#11994
akoumpa merged 11 commits intomainfrom
akoumparouli/nemo_automodel_sft_squad_fix

akoumpa commented Jan 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 30, 2025

Uh oh!

github-actions bot commented Jan 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

akoumpa commented Jan 30, 2025

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 30, 2025

Uh oh!

github-actions bot commented Jan 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants