Mask vocab padding token ids from CE loss#11999
Merged
Conversation
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
maanug-nv
force-pushed
the
maanug/mask-vocab-padding
branch
from
664da0b to
55e5c55
Compare
Contributor
|
[🤖]: Hi @maanug-nv 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
suiyoubi
approved these changes
Jan 31, 2025
Collaborator
suiyoubi
left a comment
suiyoubi
left a comment
There was a problem hiding this comment.
Thanks for adding this. LGTM
sichu2023
approved these changes
Jan 31, 2025
| vocab_start_index, _ = get_vocab_range(padded_vocab_size, rank, world_size) # gets range on this tp rank | ||
|
|
||
| # mask tokens past unpadded_vocab_size. must be offset by where each tp rank's vocab range starts | ||
| mask_start = max(unpadded_vocab_size - vocab_start_index, 0) |
BoxiangW
pushed a commit
that referenced
this pull request
Feb 7, 2025
* mask padding tokens in vocab from softmax Signed-off-by: Maanu Grover <maanug@nvidia.com> * comments and disable by default Signed-off-by: Maanu Grover <maanug@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com>
youngeunkwon0405
pushed a commit
to youngeunkwon0405/NeMo
that referenced
this pull request
Feb 10, 2025
* mask padding tokens in vocab from softmax Signed-off-by: Maanu Grover <maanug@nvidia.com> * comments and disable by default Signed-off-by: Maanu Grover <maanug@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information