Set zarr range to >=2.18.2 and <3.0.0#12005
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
|
[🤖]: Hi @chtruong814 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
| tensorstore | ||
| uvicorn | ||
| zarr | ||
| zarr>=2.18.2,<3.0.0 |
There was a problem hiding this comment.
Hey @chtruong814 👋 This file is in fact a copy of requirements_deploy.txt as there was a rename pursued recently here #11749 (comment) (because these are reqs for nemo.deploy submodule in fact).
Could you please help us to propagate the change to use requirements_deploy.txt instead of requirements_infer.txt in vLLM virtualenv setup here https://github.com/NVIDIA/NeMo/blob/18e2bd8a7012f1ad6da2bdbb248bcd6d6da6c697/reinstall.sh#L61
Otherwise I'll do that in a separate MR
CC @ko3n1g
There was a problem hiding this comment.
no worries. I don't mind making that additional change. We will also need to update the docker build in nemo-ci separately before deleting requirements_infer.txt it seems.
@thomasdhc @pablo-garay @ko3n1g we ok waiting until end of day or tomorrow even to let tests run again after I make this change? Or we just merge this now and I can open a separate MR to follow through on these other recommended changes? I'm happy to handle however y'all recommend.
There was a problem hiding this comment.
Well ok I made a reflection since pipeline passed maybe it's better to merge it as-is
There was a problem hiding this comment.
and change && remove the other file on the next occasion
There was a problem hiding this comment.
sounds good. I'll merge and open a small MR next to update to use requirements_deploy.txt and delete requirements_infer.txt.
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
3 participants
What does this PR do ?
The repo currently does not work with the dependency zarr >= 3.0, so this defines the valid range to be >= 2.18.2 and <3.0.0.
Collection: [Note which collection this PR will affect]
deploy, export, infer, nlp
Changelog
Usage
n/a
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information