Skip to content

ci: Allow skipping docs#12048

Merged
ko3n1g merged 2 commits intomainfrom
ko3n1g/ci/allow-skipping-docs
Feb 4, 2025
Merged

ci: Allow skipping docs#12048
ko3n1g merged 2 commits intomainfrom
ko3n1g/ci/allow-skipping-docs

Conversation

@ko3n1g
Copy link
Contributor

@ko3n1g ko3n1g commented Feb 4, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/allow-skipping-docs branch from 21675b7 to ec0f82d Compare February 4, 2025 20:46
@ko3n1g ko3n1g merged commit b10c3ad into main Feb 4, 2025
9 of 11 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/allow-skipping-docs branch February 4, 2025 20:46
BoxiangW pushed a commit that referenced this pull request Feb 7, 2025
* ci: Allow skipping docs

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

---------

Signed-off-by: oliver könig <okoenig@nvidia.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* ci: Allow skipping docs

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

---------

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant