Skip to content

Fix SBERT with sequence_len_offset#12057

Merged
suiyoubi merged 10 commits intomainfrom
aot/fix-sbert
Feb 8, 2025
Merged

Fix SBERT with sequence_len_offset#12057
suiyoubi merged 10 commits intomainfrom
aot/fix-sbert

Conversation

@suiyoubi
Copy link
Collaborator

@suiyoubi suiyoubi commented Feb 5, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Feb 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

[🤖]: Hi @suiyoubi 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@suiyoubi suiyoubi enabled auto-merge (squash) February 6, 2025 01:16
yaoyu-33
yaoyu-33 previously approved these changes Feb 6, 2025
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Feb 6, 2025
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Feb 7, 2025
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.38%. Comparing base (fdfeafe) to head (5c0d0d0).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12057      +/-   ##
==========================================
- Coverage   30.42%   30.38%   -0.05%     
==========================================
  Files        1400     1400              
  Lines      177452   177499      +47     
  Branches    27196    27203       +7     
==========================================
- Hits        53990    53925      -65     
- Misses     119345   119473     +128     
+ Partials     4117     4101      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

[🤖]: Hi @suiyoubi 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

suiyoubi and others added 2 commits February 7, 2025 16:34
Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Feb 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

[🤖]: Hi @suiyoubi 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@suiyoubi suiyoubi merged commit 93f0002 into main Feb 8, 2025
222 of 224 checks passed
@suiyoubi suiyoubi deleted the aot/fix-sbert branch February 8, 2025 00:55
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* Fix imcompability

* Fix imcompability

* Fix imcompability

* Fix imcompability

* set seq_len_offset

* set as kwargs for future compatibility

Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Feb 20, 2025
* Fix imcompability

* Fix imcompability

* Fix imcompability

* Fix imcompability

* set seq_len_offset

* set as kwargs for future compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants