Skip to content

Fix Linting#12079

Merged
suiyoubi merged 1 commit intomainfrom
aot/fix-linting
Feb 7, 2025
Merged

Fix Linting#12079
suiyoubi merged 1 commit intomainfrom
aot/fix-linting

Conversation

@suiyoubi
Copy link
Collaborator

@suiyoubi suiyoubi commented Feb 6, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Feb 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

[🤖]: Hi @suiyoubi 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@suiyoubi suiyoubi merged commit 90717e6 into main Feb 7, 2025
411 of 414 checks passed
@suiyoubi suiyoubi deleted the aot/fix-linting branch February 7, 2025 01:54
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.43%. Comparing base (2835153) to head (b9b9061).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12079   +/-   ##
=======================================
  Coverage   30.43%   30.43%           
=======================================
  Files        1400     1400           
  Lines      177424   177494   +70     
  Branches    27195    27202    +7     
=======================================
+ Hits        53991    54013   +22     
- Misses     119318   119358   +40     
- Partials     4115     4123    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BoxiangW pushed a commit that referenced this pull request Feb 7, 2025
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants