Skip to content

Add Automodel support for Deepseek v3 model#12099

Merged
akoumpa merged 13 commits intomainfrom
boxiangw/deepseek-automodel
Feb 11, 2025
Merged

Add Automodel support for Deepseek v3 model#12099
akoumpa merged 13 commits intomainfrom
boxiangw/deepseek-automodel

Conversation

@BoxiangW
Copy link
Collaborator

@BoxiangW BoxiangW commented Feb 7, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@BoxiangW BoxiangW requested a review from akoumpa February 7, 2025 22:03
@BoxiangW BoxiangW self-assigned this Feb 7, 2025
Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com>
BoxiangW and others added 9 commits February 7, 2025 14:21
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Signed-off-by: BoxiangW <boxiangw@nvidia.com>
Signed-off-by: BoxiangW <boxiangw@nvidia.com>
Signed-off-by: BoxiangW <boxiangw@nvidia.com>
@BoxiangW BoxiangW marked this pull request as ready for review February 10, 2025 21:51
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
@github-actions
Copy link
Contributor

[🤖]: Hi @BoxiangW 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@akoumpa akoumpa merged commit e01c41a into main Feb 11, 2025
229 checks passed
@akoumpa akoumpa deleted the boxiangw/deepseek-automodel branch February 11, 2025 02:18
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Feb 20, 2025
* Add deepseek support

Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com>

* Add comment

Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>

* Fix config
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com>

* Fix deepseek.py

Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com>

* Remove optimizer configuration func

Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>

* Update and rename deepseek.py to automodel.py

Signed-off-by: BoxiangW <boxiangw@nvidia.com>

* Update automodel.py

Signed-off-by: BoxiangW <boxiangw@nvidia.com>

* Update automodel.py

Signed-off-by: BoxiangW <boxiangw@nvidia.com>

* Address pylint change

Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>

---------

Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com>
Signed-off-by: BoxiangW <boxiangw@nvidia.com>
Co-authored-by: BoxiangW <BoxiangW@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants