Skip to content

Bug fix with generation of expert_tensor_parallel_rank#12125

Merged
akoumpa merged 2 commits intoNVIDIA-NeMo:mainfrom
guyueh1:fix_moe_etp_rank_generation
Feb 11, 2025
Merged

Bug fix with generation of expert_tensor_parallel_rank#12125
akoumpa merged 2 commits intoNVIDIA-NeMo:mainfrom
guyueh1:fix_moe_etp_rank_generation

Conversation

@guyueh1
Copy link
Collaborator

@guyueh1 guyueh1 commented Feb 10, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
@akoumpa akoumpa added Run CICD and removed Run CICD labels Feb 10, 2025
@guyueh1
Copy link
Collaborator Author

guyueh1 commented Feb 10, 2025

@akoumpa for review

@akoumpa akoumpa self-requested a review February 10, 2025 22:43
@akoumpa akoumpa enabled auto-merge (squash) February 11, 2025 01:45
@akoumpa akoumpa merged commit 387144d into NVIDIA-NeMo:main Feb 11, 2025
232 checks passed
@akoumpa akoumpa added the moe label Feb 18, 2025
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Feb 20, 2025
…2125)

* Bug fix with generation of expert_tensor_parallel_rank

Signed-off-by: Guyue Huang <guyueh@nvidia.com>

* Fix pylint

Signed-off-by: Guyue Huang <guyueh@nvidia.com>

---------

Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants