Cherry pick Fix the local path in Sortformer diarizer training tutorial (12135) into r2.2.0#12316
Merged
Cherry pick Fix the local path in Sortformer diarizer training tutorial (12135) into r2.2.0#12316
Fix the local path in Sortformer diarizer training tutorial (12135) into r2.2.0#12316Conversation
* Adding tutorial notebooks Signed-off-by: Taejin Park <tango4j@gmail.com> * Adding tutorial notebooks Signed-off-by: Taejin Park <tango4j@gmail.com> * Adding images and fix errors Signed-off-by: Taejin Park <tango4j@gmail.com> * Adding images and NeMo docs content Signed-off-by: Taejin Park <tango4j@gmail.com> * Reflected the comment on docs Signed-off-by: Taejin Park <tango4j@gmail.com> * Fixed code block issue on configs Signed-off-by: Taejin Park <tango4j@gmail.com> * Fixed the links Signed-off-by: Taejin Park <tango4j@gmail.com> * Fixed the figure and minor errors Signed-off-by: Taejin Park <tango4j@gmail.com> * Renamed tutorial notebook and updated the errors in Markdown expressions Signed-off-by: Taejin Park <tango4j@gmail.com> * Fixing docs compiling errors and warnings Signed-off-by: Taejin Park <tango4j@gmail.com> * Apply isort and black reformatting Signed-off-by: tango4j <tango4j@users.noreply.github.com> * Changed typeA | typeB to Union Signed-off-by: Taejin Park <tango4j@gmail.com> * Apply isort and black reformatting Signed-off-by: tango4j <tango4j@users.noreply.github.com> * Changed | to Union in dataloader.py Signed-off-by: Taejin Park <tango4j@gmail.com> * Apply isort and black reformatting Signed-off-by: tango4j <tango4j@users.noreply.github.com> * Changed DictConfig | to Union Signed-off-by: Taejin Park <tango4j@gmail.com> * Revert back | for native typehints Signed-off-by: Taejin Park <tango4j@gmail.com> * Added e2e diar models csv Signed-off-by: Taejin Park <tango4j@gmail.com> * Fixed e2e diar csv and conf.py Signed-off-by: Taejin Park <tango4j@gmail.com> * Pipe to Union in lhotse_dataset.py Signed-off-by: Taejin Park <tango4j@gmail.com> * Added place-holder docstrings and truncated the excessively long lines Signed-off-by: Taejin Park <tango4j@gmail.com> * Apply isort and black reformatting Signed-off-by: tango4j <tango4j@users.noreply.github.com> * Fixed the additional errors in cutset.py Signed-off-by: Taejin Park <tango4j@gmail.com> * Apply isort and black reformatting Signed-off-by: tango4j <tango4j@users.noreply.github.com> * Fixed local dir paths in Sortformer Training Notebook Signed-off-by: Taejin Park <tango4j@gmail.com> --------- Signed-off-by: Taejin Park <tango4j@gmail.com> Signed-off-by: tango4j <tango4j@users.noreply.github.com> Co-authored-by: tango4j <tango4j@users.noreply.github.com>
tango4j
approved these changes
Feb 21, 2025
Collaborator
tango4j
left a comment
tango4j
left a comment
There was a problem hiding this comment.
No tests required since these are tutorial notebooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beep boop [🤖]: Hi @tango4j 👋,