Skip to content

Cherry pick [automodel] add distributed data sampler (12326) into r2.2.0#12373

Merged
chtruong814 merged 1 commit intor2.2.0from
cherry-pick-12326-r2.2.0
Feb 26, 2025
Merged

Cherry pick [automodel] add distributed data sampler (12326) into r2.2.0#12373
chtruong814 merged 1 commit intor2.2.0from
cherry-pick-12326-r2.2.0

Conversation

@ko3n1g
Copy link
Contributor

@ko3n1g ko3n1g commented Feb 26, 2025

beep boop [🤖]: Hi @akoumpa 👋,

we've cherry picked #12326 into  for you! 🚀

Please review and approve this cherry pick by your convenience!

* add distributed data sampler

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

* pylint

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* enable dbeug

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* enable use_dist_sampler in setup

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: artbataev <artbataev@users.noreply.github.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the cherry-pick-12326-r2.2.0 branch from 08a0faa to 5a5be5a Compare February 26, 2025 01:32
@akoumpa akoumpa enabled auto-merge (squash) February 26, 2025 01:32
@github-actions
Copy link
Contributor

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@chtruong814
Copy link
Collaborator

Tests passed in this pipeline
https://github.com/NVIDIA/NeMo/actions/runs/13534428995

@chtruong814 chtruong814 disabled auto-merge February 26, 2025 07:21
@chtruong814 chtruong814 merged commit 6719c56 into r2.2.0 Feb 26, 2025
23 checks passed
@chtruong814 chtruong814 deleted the cherry-pick-12326-r2.2.0 branch February 26, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants