Add Maxine BNR 2.0 network implementation to NeMo#12655
Add Maxine BNR 2.0 network implementation to NeMo#12655anteju merged 3 commits intoNVIDIA-NeMo:mainfrom
Conversation
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
f17b28d to
e3faea0
Compare
4fd081d to
97dcd98
Compare
97dcd98 to
8ade2f6
Compare
anteju
left a comment
There was a problem hiding this comment.
LGTM!
Approved, conditioned on CI passing.
|
I believe currently we'll need to import guard torchaudio. Here's how I see it currently being imported in the code and tests for example. |
anteju
left a comment
There was a problem hiding this comment.
Add guards for torchaudio:
#12655 (comment)
|
Canceling the CI runs until after the updates are done to add the torchaudio import guards. |
|
@nitin9252, there are many issues with linting: Could you please check these locally and update the PR once all are fixed (and the unit tests are passing locally as well)? |
Signed-off-by: Nitin <28332485+nitin9252@users.noreply.github.com>
Signed-off-by: nitin9252 <nitin9252@users.noreply.github.com>
anteju
left a comment
There was a problem hiding this comment.
Looks good for now. Thanks!
Next step: please work on getting rid of torchaudio dependency and improving test coverage.
What does this PR do ?
Add Maxine BNR 2.0 network implementation to NeMo
Collection: Audio
Changelog
Usage
Please refer to added training script/tutorial
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information