Skip to content

Add Maxine BNR 2.0 network implementation to NeMo#12655

Merged
anteju merged 3 commits intoNVIDIA-NeMo:mainfrom
nitin9252:bnr_integration
Apr 30, 2025
Merged

Add Maxine BNR 2.0 network implementation to NeMo#12655
anteju merged 3 commits intoNVIDIA-NeMo:mainfrom
nitin9252:bnr_integration

Conversation

@nitin9252
Copy link
Copy Markdown
Contributor

@nitin9252 nitin9252 commented Mar 18, 2025

What does this PR do ?

Add Maxine BNR 2.0 network implementation to NeMo

Collection: Audio

Changelog

  • Add initial implementation of network + training script/tutorial

Usage

  • You can potentially add a usage example below
    Please refer to added training script/tutorial

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@nitin9252 nitin9252 marked this pull request as ready for review March 19, 2025 06:02
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Mar 19, 2025
@anteju anteju added Run CICD and removed Run CICD labels Mar 21, 2025
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Mar 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2025

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

Copy link
Copy Markdown
Collaborator

@anteju anteju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Approved, conditioned on CI passing.

@chtruong814
Copy link
Copy Markdown
Collaborator

@anteju @nitin9252

I believe currently we'll need to import guard torchaudio. Here's how I see it currently being imported in the code and tests for example.
https://github.com/NVIDIA/NeMo/blob/9d4e41e5d73a7ffeabb00a1f36982716b306dd93/nemo/collections/audio/modules/transforms.py#L24

https://github.com/NVIDIA/NeMo/blob/9d4e41e5d73a7ffeabb00a1f36982716b306dd93/tests/collections/audio/test_audio_transforms.py#L195

Copy link
Copy Markdown
Collaborator

@anteju anteju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add guards for torchaudio:
#12655 (comment)

@chtruong814
Copy link
Copy Markdown
Collaborator

Canceling the CI runs until after the updates are done to add the torchaudio import guards.

@anteju
Copy link
Copy Markdown
Collaborator

anteju commented Apr 15, 2025

@nitin9252, there are many issues with linting:
https://github.com/NVIDIA/NeMo/actions/runs/14481173762

Could you please check these locally and update the PR once all are fixed (and the unit tests are passing locally as well)?

nitin9252 and others added 3 commits April 28, 2025 17:36
Signed-off-by: Nitin <28332485+nitin9252@users.noreply.github.com>
Signed-off-by: nitin9252 <nitin9252@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@anteju anteju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. Thanks!

Next step: please work on getting rid of torchaudio dependency and improving test coverage.

@racoiaws racoiaws mentioned this pull request Apr 7, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants