Skip to content

remove language_modeling (cherry-pick of #14192)#14933

Merged
chtruong814 merged 1 commit intor2.5.0from
dpykhtar/remove_language_modelling_cherry_pick
Oct 15, 2025
Merged

remove language_modeling (cherry-pick of #14192)#14933
chtruong814 merged 1 commit intor2.5.0from
dpykhtar/remove_language_modelling_cherry_pick

Conversation

@dimapihtar
Copy link
Copy Markdown
Collaborator

  • remove language_modeling

  • fix imports

  • fix imports

  • Apply isort and black reformatting

  • fix style

  • fix style

  • fix import

  • fix imports

  • Apply isort and black reformatting

  • fix style

  • fix style

  • fix style

  • remove multimodal data unit tests

  • remove nlp

  • remove import checks for nlp

  • Apply isort and black reformatting

  • remove check imposrts for nlp

  • remove check imports for nlp

  • fix nlp imports

  • Apply isort and black reformatting

  • guard imports

  • Apply isort and black reformatting

  • fix style

  • move MegatronPretrainingBatchSampler

  • Apply isort and black reformatting

  • fix import

  • Apply isort and black reformatting

  • fix style

  • Apply isort and black reformatting

  • fix style

  • fix style

  • fix import

  • Apply isort and black reformatting

  • fix imports

  • Apply isort and black reformatting

  • fix import

  • Apply isort and black reformatting

  • fix style

  • remove multimodal test

  • fix import

  • Apply isort and black reformatting

  • remove files

  • resolve merge conflicts

  • revert changes

  • fix nlp data imports

  • Apply isort and black reformatting

  • fix style

  • Apply isort and black reformatting

  • fix style

  • move list_available_models to nlp.modules

  • Apply isort and black reformatting

  • get rid of language modelling modules

  • Apply isort and black reformatting

  • fix style

  • add Makefile

  • add Makefile


Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

* remove language_modeling

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove multimodal data unit tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove nlp

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove import checks for nlp

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove check imposrts for nlp

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove check imports for nlp

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix nlp imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* guard imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* move MegatronPretrainingBatchSampler

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove multimodal test

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove files

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* resolve merge conflicts

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* revert changes

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix nlp data imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* move list_available_models to nlp.modules

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* get rid of language modelling modules

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* add Makefile

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* add Makefile

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com>
@chtruong814 chtruong814 merged commit ab604bf into r2.5.0 Oct 15, 2025
257 of 262 checks passed
@chtruong814 chtruong814 deleted the dpykhtar/remove_language_modelling_cherry_pick branch October 15, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants