Asr numpy 2 fix #15166
Merged
Asr numpy 2 fix #15166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
erastorgueva-nv
previously approved these changes
Dec 9, 2025
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Member
Author
ko3n1g
reviewed
Dec 10, 2025
| @@ -1,2 +1 @@ | |||
| include requirements/* | |||
| include tools/ctc_segmentation/requirements.txt | |||
Collaborator
There was a problem hiding this comment.
If we remove this, the file wont be part of the shipped wheel. Is this change intentional?
Member
Author
There was a problem hiding this comment.
Yes, that is fine. Users can install it separately with tools/ctc_segmentation/requirements.txt
ko3n1g
previously approved these changes
Dec 10, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
Contributor
|
[🤖]: Hi @nithinraok 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
chtruong814
pushed a commit
that referenced
this pull request
Jan 4, 2026
* remove ctc_segmenation as part of asr Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * seperate out ctc_segmentation installation Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * remove from container installation Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> --------- Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814
pushed a commit
that referenced
this pull request
Jan 6, 2026
* remove ctc_segmenation as part of asr Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * seperate out ctc_segmentation installation Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * remove from container installation Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> --------- Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
8 tasks
chtruong814
added a commit
that referenced
this pull request
Jan 6, 2026
* Asr numpy 2 fix (#15166) * remove ctc_segmenation as part of asr Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * seperate out ctc_segmentation installation Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * remove from container installation Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> --------- Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com> * remove pinning cuda bindings (#15183) * remove pinning cuda bindings Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> * no pin Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> --------- Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Pin lhotse==1.31.1 Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
ctc_segmentation is causing numpy to <2.0 as its compiled version https://pypi.org/project/ctc-segmentation/ requires <2.0
removing it as requirement for asr and adding it seperately for tools/ctc_segmentation
Collection: ASR
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information