[voice agent][Fix] for non-EOU ASR models#15467
Closed
stevehuang52 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
Signed-off-by: He Huang (Steve) <105218074+stevehuang52@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Previously some additional logic was added to let VAD create user frames for non-EOU ASR models (e.g.,
nvidia/nemotron-speech-streaming-en-0.6b), which will cause the pipeline to send two UserStartedSpeakingFrame/UserStoppedSpeakingFrame, one by VAD and the other by TurnTakingService.In this fix, we force to only use TurnTakingService to handle those signals, since the non-EOU ASR models can be treated as an ASR-EOU model with 100% miss rate, which is already handled in the TurnTakingService.