Remove unnecessary dependencies, remove some more unused modules#15494
Draft
Remove unnecessary dependencies, remove some more unused modules#15494
Conversation
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
pzelasko
requested review from
artbataev,
blisc,
nithinraok,
racoiaws and
tango4j
blisc
reviewed
Mar 13, 2026
Comment on lines
+1
to
+5
| diskcache | ||
| matplotlib | ||
| optuna | ||
| tabulate | ||
| text-unidecode |
Collaborator
There was a problem hiding this comment.
What is the point of optional requirements?
Collaborator
Author
There was a problem hiding this comment.
Actually not sure if worth maintaining as separate file; should we just remove?
Collaborator
Author
There was a problem hiding this comment.
Oh I think my original intention was to have a convenient list handy and get them installed into containers so it's "just there", but for 99% of use cases (inference / fine tuning) users don't have to pull everything.
nithinraok
reviewed
Mar 13, 2026
nithinraok
approved these changes
Mar 14, 2026
racoiaws
reviewed
Mar 19, 2026
| pesq; (platform_machine != 'x86_64' or platform_system != 'Darwin') | ||
| pystoi |
Collaborator
There was a problem hiding this comment.
We need pystoi for measuring ESTOI during training - I think this is the most useful metric for dereverberation.
It is a requirement for torchmetrics[audio] but not torchmetrics (we have the latter)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information