Skip to content

fix: Remove nemo_class arg in import_hf.py#15596

Merged
yaoyu-33 merged 1 commit intor2.7.0from
chtruong/disable-nemo-cls
Apr 10, 2026
Merged

fix: Remove nemo_class arg in import_hf.py#15596
yaoyu-33 merged 1 commit intor2.7.0from
chtruong/disable-nemo-cls

Conversation

@chtruong814
Copy link
Copy Markdown
Collaborator

@chtruong814 chtruong814 commented Apr 10, 2026

What does this PR do ?

fix: Remove nemo_class arg in import_hf.py

We should not be using eval and an arbitrary nemo_class arg in the import_hf script. This arg is not used anywhere in the NeMo repo.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@github-actions
Copy link
Copy Markdown
Contributor

[🤖]: Hi @chtruong814 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@yaoyu-33 yaoyu-33 merged commit 57f7169 into r2.7.0 Apr 10, 2026
54 checks passed
@yaoyu-33 yaoyu-33 deleted the chtruong/disable-nemo-cls branch April 10, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants