ci: switch formatting CI to check-only and enable pre-commit hooks#15656
Merged
Conversation
The formatting workflow no longer auto-fixes and pushes commits back to PR branches. Instead it fails if black or isort find issues, shifting formatting responsibility to developers via pre-commit hooks which are now enabled (previously skipped). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
thomasdhc
previously approved these changes
May 1, 2026
chtruong814
force-pushed
the
chtruong/formatting
branch
from
a6fa62d to
ca37c32
Compare
thomasdhc
approved these changes
May 1, 2026
Contributor
|
[🤖]: Hi @chtruong814 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-formatting.yml) now runs black and isort in check-only mode — it fails the CI check instead of auto-fixing and pushing commits back to the PR branchskip: [black,isort]), so developers catch formatting issues before committinglanguage_version: python3.10pin from the black pre-commit hook (usesdefault_language_version: python3instead)Test plan
pre-commit run blackpasses on correctly formatted filespre-commit run isortpasses on correctly formatted filesFailed+ auto-fix)🤖 Generated with Claude Code