SDE local tar-base-path and text_key #15663
Merged
Merged
Conversation
Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>
Jorjeous
added a commit
that referenced
this pull request
May 11, 2026
* read manifest from s3 Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com> * Apply isort and black reformatting Signed-off-by: karpnv <karpnv@users.noreply.github.com> * s3cfg parameter Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com> * file range Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com> * Apply isort and black reformatting Signed-off-by: karpnv <karpnv@users.noreply.github.com> * Avoid downloading of full tar, instead extracting specific audio file. Updaetd logging system Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com> * Apply isort and black reformatting Signed-off-by: Jorjeous <Jorjeous@users.noreply.github.com> * shard_index + 1 Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com> * Undo latest changes, as it was dataset specific Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com> * update table to not fail on "non-string format", update bucketing and sharding with separate numeration. Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com> * add ability to read two manifests in comparison mode Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com> * Apply isort and black reformatting Signed-off-by: Jorjeous <Jorjeous@users.noreply.github.com> * removing picke; --s3cfg=AIS -- read env vars; add matching manifests my filename in case unordered manifests; Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com> * Apply isort and black reformatting Signed-off-by: Jorjeous <Jorjeous@users.noreply.github.com> * adding --force flag to load if required fields missing Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com> * update documentation, guard issues, update requrements, Added quick start and available options, lazy import for s3 dependancies Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com> * Apply isort and black reformatting Signed-off-by: Jorjeous <Jorjeous@users.noreply.github.com> * README: document _OP_/_CL_ sharded path syntax and cartesian-product expansion Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com> * SDE local tar-base-path and text_key (#15663) featire add * text Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com> * local tarr support Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com> --------- Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com> * isort and reformatting Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com> --------- Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com> Signed-off-by: karpnv <karpnv@users.noreply.github.com> Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com> Signed-off-by: Jorjeous <Jorjeous@users.noreply.github.com> Co-authored-by: Nikolay Karpov <nkarpov@nvidia.com> Co-authored-by: karpnv <karpnv@users.noreply.github.com> Co-authored-by: Jorjeous <Jorjeous@users.noreply.github.com> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: Nikolay Karpov <karpnv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support local tar files and custom text_key
Collection: ASR
Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information