Skip to content

ci: Fix CI approval queue#15693

Merged
chtruong814 merged 2 commits into
mainfrom
chtruong/fix-approval-queue
May 13, 2026
Merged

ci: Fix CI approval queue#15693
chtruong814 merged 2 commits into
mainfrom
chtruong/fix-approval-queue

Conversation

@chtruong814
Copy link
Copy Markdown
Collaborator

@chtruong814 chtruong814 commented May 12, 2026

What does this PR do ?

ci: Fix CI approval queue

This workflow is used to help manage concurrency in the CI pipelines for a repo. So if the number of in progress workflows is more than a MAX_CONCURRENCY variable, then we do not allow CI workflows to proceed.
The CI test approval queue is failing with this error occasionally. So we try to make it more robust.
https://github.com/NVIDIA-NeMo/NeMo/actions/runs/25766224227/job/75679250251

Traceback (most recent call last):
  File "<stdin>", line 111, in <module>
KeyError: 'id'
Current queued workflows: 0
Current running workflows: 0
Total workflows: 0
Max concurrency: 1
Fetching deployments...
Sorting workflows...
Processing ...
Approving workflow Merge branch 'main' into speechlm-perception-checkpoint-dtype with Run Id: 25746826150
Error making request to actions/runs/25746826150/pending_deployments: 422 Client Error: Unprocessable Entity for url: https://api.github.com/repos/NVIDIA-NeMo/NeMo/actions/runs/25746826150/pending_deployments
Response: {"message":"Validation Failed","errors":"No pending deployment requests to approve or reject","documentation_url":"https://docs.github.com/rest/actions/workflow-runs#review-pending-deployments-for-a-workflow-run","status":"422"}

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 merged commit 03fdadf into main May 13, 2026
77 checks passed
@chtruong814 chtruong814 deleted the chtruong/fix-approval-queue branch May 13, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants