Skip to content

use rapidfuzz instead of fuzzywuzzy#655

Merged
ekmb merged 1 commit intoNVIDIA-NeMo:masterfrom
maxbachmann:master
May 22, 2020
Merged

use rapidfuzz instead of fuzzywuzzy#655
ekmb merged 1 commit intoNVIDIA-NeMo:masterfrom
maxbachmann:master

Conversation

@maxbachmann
Copy link
Copy Markdown
Contributor

@maxbachmann maxbachmann commented May 22, 2020

FuzzyWuzzy and python-Levenshtein are GPLv2 or later licensed which requires to license projects that use them to be GPL Licensed aswell.
For this reason this Pullrequest replaces FuzzyWuzzy with RapidFuzz (I am the author) which is implementing the same algorithms but is based on a old version of fuzzywuzzy that was MIT Licensed.
Rapidfuzz is:

  • Mit licensed so it can be used with the license used by this project
  • Is faster than FuzzyWuzzy

Signed-off-by: maxbachmann <ssh@maxbachmann.de>
@ekmb
Copy link
Copy Markdown
Collaborator

ekmb commented May 22, 2020

@maxbachmann thank you for the PR.

@ekmb ekmb merged commit 3c87df1 into NVIDIA-NeMo:master May 22, 2020
dcurran90 pushed a commit to dcurran90/NeMo that referenced this pull request Oct 15, 2024
Now supports a diff from a specific commit
(in addition to a branch or HEAD)

Fixes NVIDIA-NeMo#654

Signed-off-by: Derek Higgins <derekh@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants