Skip to content

fix hybrid eval#7757

Merged
titu1994 merged 8 commits intomainfrom
karpnv/issue7710
Oct 19, 2023
Merged

fix hybrid eval#7757
titu1994 merged 8 commits intomainfrom
karpnv/issue7710

Conversation

@karpnv
Copy link
Collaborator

@karpnv karpnv commented Oct 19, 2023

What does this PR do ?

PR Type:

  • New Feature
  • [ V] Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

@titu1994

Additional Information

Signed-off-by: Nikolay Karpov <karpnv@gmail.com>
@karpnv karpnv requested a review from titu1994 October 19, 2023 13:45
pre-commit-ci bot and others added 3 commits October 19, 2023 13:48
Signed-off-by: Nikolay Karpov <karpnv@gmail.com>
@karpnv karpnv changed the title fix hybri fix hybrid eval Oct 19, 2023
Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>
Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>
Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>
titu1994
titu1994 previously approved these changes Oct 19, 2023
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@karpnv karpnv requested a review from titu1994 October 19, 2023 17:09
@titu1994 titu1994 merged commit e57aff0 into main Oct 19, 2023
@titu1994 titu1994 deleted the karpnv/issue7710 branch October 19, 2023 17:10
burchim pushed a commit to burchim/NeMo that referenced this pull request Oct 28, 2023
* fix

Signed-off-by: Nikolay Karpov <karpnv@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* rename

Signed-off-by: Nikolay Karpov <karpnv@gmail.com>

* docs

Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>

* warning

Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>

* if

Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>

---------

Signed-off-by: Nikolay Karpov <karpnv@gmail.com>
Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nikolay Karpov <nkarpov@nvidia.com>
Signed-off-by: maxime burchi <maxime.burchi@gmail.com>
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
* fix

Signed-off-by: Nikolay Karpov <karpnv@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* rename

Signed-off-by: Nikolay Karpov <karpnv@gmail.com>

* docs

Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>

* warning

Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>

* if

Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>

---------

Signed-off-by: Nikolay Karpov <karpnv@gmail.com>
Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nikolay Karpov <nkarpov@nvidia.com>
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* fix

Signed-off-by: Nikolay Karpov <karpnv@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* rename

Signed-off-by: Nikolay Karpov <karpnv@gmail.com>

* docs

Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>

* warning

Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>

* if

Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>

---------

Signed-off-by: Nikolay Karpov <karpnv@gmail.com>
Signed-off-by: Nikolay Karpov <nkarpov@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nikolay Karpov <nkarpov@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants