First draft of mcore bert model in NeMo#7814
Merged
shanmugamr1992 merged 73 commits intomainfrom Dec 15, 2023
Merged
Conversation
for more information, see https://pre-commit.ci
Collaborator
|
/jenkins |
Signed-off-by: Eric Harper <complex451@gmail.com>
ericharper
reviewed
Nov 3, 2023
ericharper
reviewed
Nov 3, 2023
Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ericharper
reviewed
Nov 8, 2023
ericharper
reviewed
Nov 8, 2023
nemo/collections/nlp/models/language_modeling/megatron_bert_model.py
Outdated
Show resolved
Hide resolved
ericharper
reviewed
Nov 8, 2023
nemo/collections/nlp/models/language_modeling/megatron_bert_model.py
Outdated
Show resolved
Hide resolved
ericharper
reviewed
Nov 8, 2023
nemo/collections/nlp/models/language_modeling/megatron_bert_model.py
Outdated
Show resolved
Hide resolved
ericharper
reviewed
Nov 8, 2023
nemo/collections/nlp/models/language_modeling/megatron_bert_model.py
Outdated
Show resolved
Hide resolved
ericharper
reviewed
Nov 8, 2023
nemo/collections/nlp/models/language_modeling/megatron_base_model.py
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
/jenkins |
Collaborator
Author
|
jenkins |
Collaborator
Author
|
jenkins |
1 similar comment
Collaborator
Author
|
jenkins |
Collaborator
Author
|
jenkins |
Collaborator
Author
|
jenkins |
Collaborator
Author
|
jenkins |
Collaborator
Author
|
jenkins |
Collaborator
Author
|
jenkins |
for more information, see https://pre-commit.ci
Collaborator
Author
|
jenkins |
ericharper
requested changes
Dec 14, 2023
Collaborator
ericharper
left a comment
ericharper
left a comment
There was a problem hiding this comment.
Jenkinsfile has a bunch of tests removed please revert.
Collaborator
Author
|
jenkins |
8 tasks
pzelasko
pushed a commit
to pzelasko/NeMo
that referenced
this pull request
Jan 3, 2024
* First draft of mcore bert model in NeMo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * First draft of mcore bert model in Nemo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Addressed eric's comments * Added a ci test * Removing unused imports * Addressing eric's comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Addressing eric's comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update Jenkinsfile Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com> * Changing mcore version * Fixing tests * Checking mcore and bert installation * Adding latest megatron lm commit * Adding latest megatron lm commit * Adding latest megatron lm commit * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update Jenkinsfile Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com> * Seeing failure for the import * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixing tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Adding bert model imports to mcore model part * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Dummy change * Testing bert stuff alone * Testing bert stuff alone * Testing bert stuff alone * Adding bert model imports to mcore model part * Adding bert model imports to mcore model part * Fixing bert code * Fixing bert code * Fixing bert code * Fixing bert code * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bert * fix bert * fix bert * fix bert * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bert * fix bert * fix bert * fix bert * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert oriignal jenksins file --------- Signed-off-by: Eric Harper <complex451@gmail.com> Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com> Co-authored-by: shanmugamr <shanmugamr@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric Harper <complex451@gmail.com> Co-authored-by: Shanmugam Ramasamy <shanmugamr@shanmugamr-mlt.client.nvidia.com> Signed-off-by: Piotr Żelasko <petezor@gmail.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
* First draft of mcore bert model in NeMo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * First draft of mcore bert model in Nemo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Addressed eric's comments * Added a ci test * Removing unused imports * Addressing eric's comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Addressing eric's comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update Jenkinsfile Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com> * Changing mcore version * Fixing tests * Checking mcore and bert installation * Adding latest megatron lm commit * Adding latest megatron lm commit * Adding latest megatron lm commit * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update Jenkinsfile Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com> * Seeing failure for the import * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixing tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Adding bert model imports to mcore model part * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Dummy change * Testing bert stuff alone * Testing bert stuff alone * Testing bert stuff alone * Adding bert model imports to mcore model part * Adding bert model imports to mcore model part * Fixing bert code * Fixing bert code * Fixing bert code * Fixing bert code * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bert * fix bert * fix bert * fix bert * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bert * fix bert * fix bert * fix bert * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert oriignal jenksins file --------- Signed-off-by: Eric Harper <complex451@gmail.com> Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com> Co-authored-by: shanmugamr <shanmugamr@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric Harper <complex451@gmail.com> Co-authored-by: Shanmugam Ramasamy <shanmugamr@shanmugamr-mlt.client.nvidia.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* First draft of mcore bert model in NeMo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * First draft of mcore bert model in Nemo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Addressed eric's comments * Added a ci test * Removing unused imports * Addressing eric's comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Addressing eric's comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update Jenkinsfile Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com> * Changing mcore version * Fixing tests * Checking mcore and bert installation * Adding latest megatron lm commit * Adding latest megatron lm commit * Adding latest megatron lm commit * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update Jenkinsfile Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com> * Seeing failure for the import * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixing tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Adding bert model imports to mcore model part * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Dummy change * Testing bert stuff alone * Testing bert stuff alone * Testing bert stuff alone * Adding bert model imports to mcore model part * Adding bert model imports to mcore model part * Fixing bert code * Fixing bert code * Fixing bert code * Fixing bert code * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bert * fix bert * fix bert * fix bert * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bert * fix bert * fix bert * fix bert * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert oriignal jenksins file --------- Signed-off-by: Eric Harper <complex451@gmail.com> Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com> Co-authored-by: shanmugamr <shanmugamr@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric Harper <complex451@gmail.com> Co-authored-by: Shanmugam Ramasamy <shanmugamr@shanmugamr-mlt.client.nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds the mcore bert model to the nemo codebase.
Collection: nlp collection
Usage
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information