Pass in rotary_base to mcore and from HF#7933
Merged
ericharper merged 5 commits intoNVIDIA-NeMo:mainfrom Dec 3, 2023
Merged
Conversation
Signed-off-by: Igor Gitman <igitman@nvidia.com>
Signed-off-by: Igor Gitman <igitman@nvidia.com>
Collaborator
|
jenkins |
Signed-off-by: Igor Gitman <igitman@nvidia.com>
Collaborator
|
jenkins |
Contributor
|
This PR incremented the version of Megatron Core from |
pzelasko
pushed a commit
to pzelasko/NeMo
that referenced
this pull request
Jan 3, 2024
* Pass in rotary_base to mcore and from HF Signed-off-by: Igor Gitman <igitman@nvidia.com> * Allow changing rotary_base from the sft config file Signed-off-by: Igor Gitman <igitman@nvidia.com> * Update mcore in jenkins Signed-off-by: Igor Gitman <igitman@nvidia.com> --------- Signed-off-by: Igor Gitman <igitman@nvidia.com> Co-authored-by: Eric Harper <complex451@gmail.com> Signed-off-by: Piotr Żelasko <petezor@gmail.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
* Pass in rotary_base to mcore and from HF Signed-off-by: Igor Gitman <igitman@nvidia.com> * Allow changing rotary_base from the sft config file Signed-off-by: Igor Gitman <igitman@nvidia.com> * Update mcore in jenkins Signed-off-by: Igor Gitman <igitman@nvidia.com> --------- Signed-off-by: Igor Gitman <igitman@nvidia.com> Co-authored-by: Eric Harper <complex451@gmail.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Pass in rotary_base to mcore and from HF Signed-off-by: Igor Gitman <igitman@nvidia.com> * Allow changing rotary_base from the sft config file Signed-off-by: Igor Gitman <igitman@nvidia.com> * Update mcore in jenkins Signed-off-by: Igor Gitman <igitman@nvidia.com> --------- Signed-off-by: Igor Gitman <igitman@nvidia.com> Co-authored-by: Eric Harper <complex451@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This depends on the following mcore commit NVIDIA/Megatron-LM@d931ba8, so if it's not yet integrated into our main branch, we'd need to wait before merging this PR.
Collection: NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information